add the ability to set the leader url #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenoromm
requested review from
mQkatz,
abetones,
Maliha-Writes,
stevelitras and
bieron
as code owners
|
Would love to get this reviewed and make changes if it is something minor holding this back |
konradmars
approved these changes
Jun 25, 2024
a-klebanov
reviewed
Jul 19, 2024
| @@ -45,6 +45,7 @@ This section covers the most likely values to override. To see the full scope of | |||
| |---|----|-------------| | |||
| |config.adminPassword|String|The password you want the admin user to have set.| | |||
| |config.token|String|The auth key you want to set up for worker access. The Cribl Stream instance is configured as a distributed leader server only if this value is set. (This can, of course, also be configured via the Cribl Stream UI.) | | |||
| |config.leaderUrl|String|When setting config.token, the env vars CRIBL_DIST_MASTER_URL and CRIBL_DIST_LEADER_URL are set, this value allows overriding the default string. This can allow you to enforce TLS leadercoms or other settings configured with this string. | | |||
There was a problem hiding this comment.
The goal here is to use tls:// in URL or there are other reasons to override leader URL?
If so, I would suggest to introduce a new variable in values like leaderProtocol (may be not the best name) to use:
"%s://%s@%s:4200" .Values.config.leaderProtocol .Values.config.token .Values.config.token .Values.config.bindHost
There was a problem hiding this comment.
Since instance.yml is ignored when CRIBL_DIST_* environment vars are set, all settings available in instance.yml (cert locations, tls version, mTLS etc) may need to be configured here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows functionality discussed in #192.
When setting these values explicitly as environment variables, it fails due to duplicate keys. Changes to files on the leader are also ignored, this allows the values to be set cleanly.