Fix #4: Escape percent sign character.

Author: TiSiE

src/YawikXingVendorApi/Filter/XingData/Basic.php

@@ -71,7 +71,6 @@ public function filter($value)
                  ->setCompanyName($companyName)
                  ->setDisciplineId($disciplineId)
                  ->setCountry('DE')
-                 ->setFunction($job->getTitle())
                  ->setIndustryId(isset($xingOpts['industry']) ? $xingOpts['industry'] : 230000)
                  ->setLanguage('de')
                  ->setReplySetting(XingData::REPLY_SETTINGS_EMAIL)

src/YawikXingVendorApi/Filter/XingData/Description.php

@@ -37,6 +37,10 @@ public function filter($value)
         $jobLink = $xingData->getPostingUrl();
         $description = $xingData->getDescription();
 
+        $title = $this->escapePercent($value->getJob()->getTitle());
+        $logger && $logger->info('---> Set title to "' . $title . '"');
+        $xingData->setFunction($title);
+
         if (!$jobLink && !$description) {
             $logger && $logger->warn('No posting url in the Xing data object. Cannot fetch description.');
             return 'Missing posting_url. Cannot fetch description.';
@@ -81,8 +85,6 @@ public function filter($value)
         $stripTags->setAttributesAllowed(array());
         $description = trim(html_entity_decode($stripTags($dom->saveHTML())));
 
-        // Xing does not accept a '%' sign. 
-        $description = preg_replace('/%/','%',$description);
 
         if (false === $description) {
             $data = $value->getData();
@@ -93,11 +95,18 @@ public function filter($value)
             $logger && $logger->notice('----> No description recieved. Fall back to transmitted description.');
             $return = 'Fetching description failed. Used transmitted description.';
         }
+        // Xing does not accept a '%' sign.
+        $description = $this->escapePercent($description);
+
 
         $xingData->setDescription($description);
 
         return $return;
     }
 
+    private function escapePercent($str)
+    {
+        return str_replace('%', '\u0025', $str);
+    }
 
-}
+}

test/TestConfig.php

@@ -10,8 +10,9 @@
 
 return array(
     // This should be an array of module namespaces used in the application.
-    'modules' => array(
-        'Core', 'Auth', 'Jobs', 'YawikXingVendorApi'
+    'modules' => array_merge(
+            include_once __DIR__.'/../../../config/common.modules.php',
+            [ 'Core', 'Auth', 'Jobs', 'YawikXingVendorApi' ]
     ),
 
     // These are various options for the listeners attached to the ModuleManager

test/YawikXingVendorApiTest/Filter/XingData/DescriptionTest.php

@@ -10,6 +10,7 @@
 /** */
 namespace YawikXingVendorApiTest\Filter\XingData;
 
+use Jobs\Entity\Job;
 use YawikXingVendorApi\Entity\XingData;
 use YawikXingVendorApi\Filter\XingData\Description;
 use YawikXingVendorApi\Filter\XingFilterData;
@@ -51,6 +52,19 @@ public function testImplementsZfFilterInterface()
     }
 
 
+    public function testSetJobTitleInXingData()
+    {
+        $job = new Job();
+        $job->setTitle('Test%Job');
+
+        $xingData = new XingData();
+        $xingFilterData = new XingFilterData($xingData, null, [], $job);
+
+        $this->filter->filter($xingFilterData);
+
+        $this->assertEquals('Test\u0025Job', $xingData->getFunction());
+    }
+
     /**
      * Tests if attributes are stripped.
      *
@@ -74,19 +88,21 @@ public function testDescriptionWithAttributesInTags($input, $expected)
      */
     public function provideHtml()
     {
+        $job = new Job();
+        $job->setTitle('TestJobTitle');
 
         $xingData = new XingData();
         $xingData->setDescription('<p style="test">foobar</p>');
-        $xingFilterData1 = new XingFilterData($xingData, null, [] ,null, null);
+        $xingFilterData1 = new XingFilterData($xingData, null, [] ,$job, null);
 
         $xingData = new XingData();
         $xingData->setDescription('<p style="test">foo % bar</p> replace % by entity');
-        $xingFilterData2 = new XingFilterData($xingData, null, [] ,null, null);
+        $xingFilterData2 = new XingFilterData($xingData, null, [] ,$job, null);
 
 
         return array(
             [$xingFilterData1,'<p>foobar</p>'],
-            [$xingFilterData2,'<p>foo &percnt; bar</p> replace &percnt; by entity'],
+            [$xingFilterData2,'<p>foo \u0025 bar</p> replace \u0025 by entity'],
         );
     }
-}
+}