From 1f970c837ca318b5fbbf0e2c4f30b299e25efc55 Mon Sep 17 00:00:00 2001 From: thde Date: Wed, 27 Mar 2024 11:09:17 +0100 Subject: [PATCH] fix(helm): skip login if no credentials are provided Signed-off-by: thde --- pkg/clients/helm/client.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/clients/helm/client.go b/pkg/clients/helm/client.go index 24b6c08..3759453 100644 --- a/pkg/clients/helm/client.go +++ b/pkg/clients/helm/client.go @@ -221,9 +221,11 @@ func (hc *client) pullChart(spec *v1beta1.ChartSpec, creds *RepoCreds, chartDir pc.DestDir = chartDir - err := hc.login(spec, creds, pc.InsecureSkipTLSverify) - if err != nil { - return err + if creds.Username != "" && creds.Password != "" { + err := hc.login(spec, creds, pc.InsecureSkipTLSverify) + if err != nil { + return err + } } o, err := pc.Run(chartRef)