Add Proxy Support #196
Add Proxy Support #196
Conversation
Signed-off-by: Armin Barton <ab5@xxxlgroup.com>
| @@ -202,6 +205,14 @@ func (c *connector) Connect(ctx context.Context, mg resource.Managed) (managed.E | |||
| } | |||
| } | |||
|
|
|||
| if proxy := p.Spec.Proxy; proxy != "" { | |||
There was a problem hiding this comment.
Wouldn't it work by passing proxy/no_proxy environment variables via a ControllerConfig ? https://www.oreilly.com/library/view/security-with-go/9781788627917/5ea6a02b-3d96-44b1-ad3c-6ab60fcbbe4f.xhtml
Go's default HTTP client will respect the system's HTTP(S) proxy if set through environment variables. Go uses the HTTP_PROXY, HTTPS_PROXY and NO_PROXY environment variables. The lowercase versions are also valid.
There was a problem hiding this comment.
This would work when we only need to connect to a single proxy instance per controller.
In our case, we use a single Crossplane/Helm provider instance to manage many clusters in various VPC networks. As a result, we have to connect to a different proxy instance depending on the specific Cluster/Vpc.
There was a problem hiding this comment.
Hi @turkenh ,
Is there any update on this PR?
Description of your changes
Adds a proxy support for connecting to the Kubernetes API server.
Fixes #195
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested it manually by installing a helm chart via a proxy.