Skip to content

Update dead link in providers.md #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

matmilbury
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 8bfbb24
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/67fd3e065fad4300084d56e9
😎 Deploy Preview https://deploy-preview-889--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 8 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -22,7 +22,7 @@ Examples of providers include:
* [Provider Kubernetes](https://github.com/crossplane-contrib/provider-kubernetes)

{{< hint "tip" >}}
Find more providers in Crossplane's [public package registries](https://www.crossplane.io/registries).
Find more providers in Crossplane's [public package registries](https://marketplace.upbound.io/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @matmilbury! We should actually remove this link entirely. For vendor neutrality, we don't want to link directly to the upbound marketplace at all.

There's a similar hit that should be also entirely removed at https://github.com/crossplane/docs/blob/master/content/master/getting-started/introduction.md#providers

Would you be able to make these changes across all the version folders in the content dir? i.e. v1.17, v1.18, v1.19, and master? That would be really helpful! 🙇‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matmilbury someone brought this up in Crossplane slack again today, so I went ahead and pushed a commit to your branch that fixes all the locations, and kept you as the commit author 😉

@jbw976 jbw976 force-pushed the patch-1 branch 2 times, most recently from 860814e to 1d99200 Compare April 14, 2025 16:50
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the initiative on this @matmilbury! 🙇‍♂️

@jbw976 jbw976 merged commit dc192ed into crossplane:master Apr 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants