Skip to content

Add runtimeClassName value to crossplane helm chart docs #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adrienfuss
Copy link
Contributor

Description

Related PR : crossplane/crossplane#6387
Related issue : crossplane/crossplane#6386

Signed-off-by: adrienfuss <adrien.fuss@doctolib.com>
Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 6993215
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/680a4b5d4f5a99000802481f
😎 Deploy Preview https://deploy-preview-918--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🔴 down 6 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbw976
Copy link
Member

jbw976 commented Apr 24, 2025

looks like Vale is unhappy with the spelling of runtimeClassName:

 176:28   error    Spelling check:                 Crossplane.Spelling 
                   "runtimeClassName"?                                 

I think we can add an exception to https://github.com/crossplane/docs/blob/master/utils/vale/styles/Crossplane/allowed-jargon.txt 🙏

Signed-off-by: adrienfuss <adrien.fuss@doctolib.com>
@jbw976
Copy link
Member

jbw976 commented Apr 24, 2025

Awesome, thanks for making this docs update to go along with your contribution in crossplane/crossplane#6387! 🎉

@jbw976 jbw976 merged commit de4c3a3 into crossplane:master Apr 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants