fix: suppress error notifications & reload issue (#151)

Author: yevheniyJ

src/constants.ts

@@ -34,6 +34,7 @@ export class Constants {
     static readonly CLIENT_RETRIES = 5;
     static readonly CLIENT_RETRY_WAIT_INTERVAL_MS = 750;
     static VSCODE_VERSION: string;
+    static APPLICATION_OPENED = false;
 
     static initialize(context: vscode.ExtensionContext) {
         Constants.VSCODE_VERSION = vscode.version;

src/extension.ts

@@ -18,7 +18,7 @@ export function activate(context: vscode.ExtensionContext) {
     configHolder.addListener(() => filesProvider.refresh());
     configHolder.addListener(() => progressProvider.refresh());
     configHolder.addListener(setConfigExists);
-    configHolder.load();
+    configHolder.initialize();
 
     OAuth.initialize(context, () => configHolder.reload());
 

src/plugin/crowdinConfigHolder.ts

@@ -10,12 +10,14 @@ export class CrowdinConfigHolder {
     private configurationToWorkspace: Map<ConfigModel, vscode.WorkspaceFolder> = new Map();
     private sourceStrings: Map<vscode.WorkspaceFolder, crowdin.SourceStringsModel.String[]> = new Map();
     private listeners: { (): void }[] = [];
+    private initializer: Promise<void> = Promise.resolve();
 
     addListener(listener: () => void) {
         this.listeners.push(listener);
     }
 
-    get configurations(): Map<ConfigModel, vscode.WorkspaceFolder> {
+    async configurations(): Promise<Map<ConfigModel, vscode.WorkspaceFolder>> {
+        await this.initializer;
         return this.configurationToWorkspace;
     }
 
@@ -27,6 +29,10 @@ export class CrowdinConfigHolder {
         this.configurationToWorkspace.forEach((workspace, config) => this.loadStrings(config, workspace));
     }
 
+    initialize() {
+        this.initializer = this.load();
+    }
+
     async load() {
         const workspaceFolders = vscode.workspace.workspaceFolders || [];
         let configFiles: string[] = [];
@@ -79,14 +85,8 @@ export class CrowdinConfigHolder {
         });
         watchersToAdd.forEach((file) => {
             const wather = vscode.workspace.createFileSystemWatcher(file);
-            wather.onDidChange(async () => {
-                await this.load();
-                this.listeners.forEach((l) => l());
-            });
-            wather.onDidDelete(async () => {
-                await this.load();
-                this.listeners.forEach((l) => l());
-            });
+            wather.onDidChange(this.reload);
+            wather.onDidDelete(this.reload);
             this.configWatchers.set(file, wather);
         });
     }

src/plugin/files/filesProvider.ts

@@ -1,4 +1,5 @@
 import * as vscode from 'vscode';
+import { Constants } from '../../constants';
 import { AUTH_TYPE, SCOPES } from '../../oauth/constants';
 import { CommonUtil } from '../../util/commonUtil';
 import { ErrorHandler } from '../../util/errorHandler';
@@ -88,6 +89,7 @@ export class FilesProvider implements vscode.TreeDataProvider<FilesTreeItem> {
     }
 
     async getChildren(element?: FilesTreeItem): Promise<FilesTreeItem[]> {
+        Constants.APPLICATION_OPENED = true;
         if (!element && this.showWelcomeMessage) {
             const session = await vscode.authentication.getSession(AUTH_TYPE, SCOPES, { createIfNone: false });
             if (session) {
@@ -109,7 +111,7 @@ export class FilesProvider implements vscode.TreeDataProvider<FilesTreeItem> {
     }
 
     private async buildRootTree(): Promise<FilesTreeItem[]> {
-        const configurations = this.configHolder.configurations;
+        const configurations = await this.configHolder.configurations();
         const promises = Array.from(configurations).map(async ([config, workspace]) => {
             try {
                 const rootTreeFolder = await FilesTreeBuilder.buildRootFolder(

src/plugin/progress/progressTreeProvider.ts

@@ -22,9 +22,10 @@ export class ProgressTreeProvider implements vscode.TreeDataProvider<ProgressTre
         return element;
     }
 
-    getChildren(element?: ProgressTreeItem): Thenable<any[]> {
+    async getChildren(element?: ProgressTreeItem): Promise<any[]> {
         if (!element) {
-            const promises = Array.from(this.configHolder.configurations).map(async ([config, workspace]) => {
+            const configurations = await this.configHolder.configurations();
+            const promises = Array.from(configurations).map(async ([config, workspace]) => {
                 try {
                     const client = buildClient(workspace.uri, config);
                     const { translationStatusApi, projectsGroupsApi, languagesApi } = client.crowdin;

src/util/errorHandler.ts

@@ -1,7 +1,11 @@
 import * as vscode from 'vscode';
+import { Constants } from '../constants';
 
 export class ErrorHandler {
     static handleError(e: any): void {
+        if (!Constants.APPLICATION_OPENED) {
+            return;
+        }
         let message;
         if (typeof e === 'string') {
             message = e;