Skip to content

Commit 666cd0a

Browse files
committed
fix: grant more permissions to cloud node lifecycle controller
1 parent 73e4369 commit 666cd0a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: internal/node/utils.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,17 @@ func StartCloudNodeLifecycleControllerWrapper(initContext app.ControllerInitCont
2929

3030
//nolint:gocritic // need to follow upstream function signature
3131
func startCloudNodeLifecycleController(ctx context.Context,
32-
initContext app.ControllerInitContext,
32+
_ app.ControllerInitContext,
3333
controlexContext controllermanagerapp.ControllerContext,
3434
completedConfig *config.CompletedConfig,
3535
cloud cloudprovider.Interface,
3636
) (controller.Interface, bool, error) {
3737
// Start the cloudNodeLifecycleController
3838
cloudNodeLifecycleController, err := NewCloudNodeLifecycleController(
3939
completedConfig.SharedInformers.Core().V1().Nodes(),
40-
// cloud node lifecycle controller uses existing cluster role from node-controller
41-
completedConfig.ClientBuilder.ClientOrDie(initContext.ClientName),
40+
// use crusoe-ccm-sa ServiceAccount because custom node lifecycle controller needs
41+
// permissions to list and delete VolumeAttachments
42+
completedConfig.ClientBuilder.ClientOrDie("crusoe-ccm-sa"),
4243
cloud,
4344
completedConfig.ComponentConfig.KubeCloudShared.NodeMonitorPeriod.Duration,
4445
)

0 commit comments

Comments
 (0)