Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Agent auto-config for harvester #1057

Open
andrewazores opened this issue Feb 18, 2025 · 1 comment
Open

[Request] Agent auto-config for harvester #1057

andrewazores opened this issue Feb 18, 2025 · 1 comment
Labels
feat New feature or request question Further information is requested

Comments

@andrewazores
Copy link
Member

Describe the feature

Currently the agent autoconfiguration only supports setting the harvester template, but no other harvester parameters. This only allows for on-stop uploads of recordings, but it would be nice to support periodic pushes as well.

Anything other information?

No response

@andrewazores andrewazores added the feat New feature or request label Feb 18, 2025
@andrewazores
Copy link
Member Author

andrewazores commented Feb 20, 2025

Maybe this is not really needed in the end.

spec:
  template:
    metadata:
      labels:
        cryostat.io/name: cryostat
        cryostat.io/namespace: cryostat
        cryostat.io/harvester-template: default
    spec:
      containers:
        - env:
            - name: CRYOSTAT_AGENT_HARVESTER_PERIOD_MS
              value: '30000'
            - name: CRYOSTAT_AGENT_HARVESTER_MAX_FILES
              value: '3'

This kind of Deployment snippet can already be applied, which uses the operator's Autoconfig to set up the Agent, but also contains additional manually-specified environment variables that the Agent will pick up and use to configure the Harvester further. It doesn't look as clean and tidy as having it all configured in one place (ie. the Pod labels), but it's functional and generally understandable. Adding full support for all Agent configurations to the autoconfiguration labels means more effort and maintenance in making sure any new Agent configuration parameters get mirrored as autoconfiguration labels.

@andrewazores andrewazores added the question Further information is requested label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant