-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consoleplugin): operator installs and configures ConsolePlugin #1023
Conversation
b06afe1
to
9ae5035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove some more pieces here since we aren't using the patcher Job anymore.
config/openshift/console-plugin/clusterrolebinding-cryostat-plugin-patcher.yaml
Outdated
Show resolved
Hide resolved
config/openshift/console-plugin/clusterrole-cryostat-plugin-patcher.yaml
Outdated
Show resolved
Hide resolved
5033edb
to
ecd07f5
Compare
ecd07f5
to
fae99bd
Compare
This reverts commit 0164427.
It seems like this happens because the console plugin installation tries to use the Kubernetes client to create resources (like the ConsolePlugin CR), but since this is being done before |
I'll try using the direct (non-cached) Kubernetes client and see if that works. |
That last commit converts the plugin installer to a For the separate issue of OLM naming the ClusterRoleBinding's unpredictably, I found a shared set of OLM-managed labels between the operator deployment and the ClusterRoleBinding. I use this to find the ClusterRoleBindings belonging to our operator and then iterate until we find the one with the proper Service Account subject. These two things seemed to work well when tested on OpenShift 4.17. |
/build_test |
|
GitHub won't let me approve this PR because I'm still technically its author 😁 Looks good and appears to work great. Maintainer override coming up. |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #
Related to cryostatio/cryostat-openshift-console-plugin#3
Description of the change:
This change adds allows the users to provide...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: