Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add label for read-only agent #1029

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Jan 28, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #996

Description of the change:

  • Adds cryostat.io/read-only label to allow users to make the injected agent read-only.

Motivation for the change:

  • Gives users more control over security of their injected agents

How to manually test:

  1. Deploy this PR and create default CR
  2. make sample_app_injected, should inject with write access turned on
  3. Edit deployment with cryostat.io/read-only: true, should inject with write access turned off

@ebaron ebaron added the feat New feature or request label Jan 28, 2025
@ebaron ebaron requested a review from a team January 28, 2025 19:52
@mergify mergify bot added the safe-to-test label Jan 28, 2025
@ebaron
Copy link
Member Author

ebaron commented Jan 28, 2025

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bananas are definitely non-boolean. Approved

@ebaron ebaron force-pushed the agent-write-label branch from e7e0f83 to 1246802 Compare January 29, 2025 14:59
@ebaron ebaron merged commit 7d36651 into cryostatio:main Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Story] Add a label to control write permissions for agent
2 participants