fix(service): set appProtocol to https if TLS enabled #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
appprotocol-https
branch
from
5e64cfd to
dca1ea1
Compare
|
/build_test |
|
|
ebaron
approved these changes
Jan 29, 2025
andrewazores
force-pushed
the
appprotocol-https
branch
from
dca1ea1 to
d0be271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Fixes: #1033
Related to cryostatio/cryostat-openshift-console-plugin#3
Description of the change:
Sets the
appProtocolof the Cryostat service port tohttpsif TLS is enabled, otherwise leaves it ashttp.Motivation for the change:
This is used as a marker for other components to know whether the exposed service port is using HTTPS or HTTP. The console plugin backend uses the appProtocol first to determine whether it should send HTTPS or HTTP requests to the Cryostat instance. If it does not find an appProtocol on the port then it falls back to trying to use the port name. If it still cannot determine what the port is, then it bails out.
How to manually test: