Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(insights): add Kustomize patch to adjust pull policy #1045

Merged
merged 1 commit into from
Feb 5, 2025
Merged

build(insights): add Kustomize patch to adjust pull policy #1045

merged 1 commit into from
Feb 5, 2025

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Feb 5, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #691

Description of the change:

  • Adds a Kustomize patch to control pull policy in the same way we do for the operator controller and console plugin

Motivation for the change:

  • Makes pull policy consistent across images

How to manually test:

  1. make bundle

@ebaron ebaron added chore Refactor, rename, cleanup, etc. backport build labels Feb 5, 2025
@ebaron ebaron requested a review from a team February 5, 2025 21:29
@mergify mergify bot added the safe-to-test label Feb 5, 2025
@ebaron
Copy link
Member Author

ebaron commented Feb 5, 2025

/build_test

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit 96468b6 into cryostatio:main Feb 5, 2025
7 checks passed
mergify bot pushed a commit that referenced this pull request Feb 5, 2025
@ebaron @mergify
build(insights): add Kustomize patch to adjust pull policy (#1045)
2dd5538 
(cherry picked from commit 96468b6)
@mergify mergify bot mentioned this pull request Feb 5, 2025
Merged
7 tasks
ebaron added a commit that referenced this pull request Feb 5, 2025
@mergify @ebaron
build(insights): add Kustomize patch to adjust pull policy (#1045) (#…
995677c 
…1046)

(cherry picked from commit 96468b6)

Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport build chore Refactor, rename, cleanup, etc. safe-to-test
Projects
4.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Story] Move Insights integration into its own repo
2 participants
@ebaron @andrewazores