-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(discovery): ensure consistent names for discovery options in CRD #828
Conversation
/build_test |
|
/build_test |
|
/build_test |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be fine. I like the consistency as well. Just need another make bundle
I think.
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Sounds good! Updated now :D |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Related to #715
Description of the change:
v1beta2
as such? Otherwise, I can just update the docs only.Motivation for the change:
Documentation might be confusing as they state the opposite of what the fields should do.