fix(custom-targets): lock form Create button until successful test (#…

…1262) * fix(custom-targets): handle case where response does not include data or reason fields * fix(custom-targets): lock form Create button until successful test
cryostatio · May 31, 2024 · 759e8ae · 759e8ae
1 parent c133e6e
commit 759e8ae
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/app/Topology/Actions/CreateTarget.tsx b/src/app/Topology/Actions/CreateTarget.tsx
@@ -185,9 +185,10 @@ export const CreateTarget: React.FC<CreateTargetProps> = ({ prefilled }) => {
           if (option === ValidatedOptions.success) {
             exitForm();
           } else {
+            let errorMessage = (body as any)?.data?.reason || 'Connection test failure';
             setValidation({
               option: option,
-              errorMessage: body['data']['reason'],
+              errorMessage,
             });
           }
         }),
@@ -408,7 +409,7 @@ export const CreateTarget: React.FC<CreateTargetProps> = ({ prefilled }) => {
             <ActionGroup>
               <Button
                 variant="primary"
-                isDisabled={!connectUrl || validConnectUrl !== ValidatedOptions.success || loading || testing}
+                isDisabled={validation.option !== ValidatedOptions.success}
                 onClick={handleSubmit}
                 {...createButtonLoadingProps}
                 data-quickstart-id="ct-create-btn"