feat(error): set error boundary for first renders #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Related to: #950
Description of the change:
Add an error boundary around component that renders the main container view. Though, this won't completely fix the issue because we need consider more granular handling.
Note: this applies for first render. If later one child components build fail, no error views will be shown.
Motivation for the change:
See #950. This applies to first renders to that errors are caught early.
How to manually test:
Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
Screenshots