Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] URI range validation is inconsistently applied to different target discovery mechanisms #685

Closed
andrewazores opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Current Behavior

See #323 (#323 (comment))
See #444

// TODO apply URI range validation to the remote address

URI range validation should also be applied at the locations above, so that not only Custom Targets are validated to be within the expected range, but also that Discovery Plugins are within range and any targets published by Discovery Plugins are within range.

It may make sense to do this validation in the pre-persist hooks, ex.

void prePersist(Target target) {

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@andrewazores andrewazores added the bug Something isn't working label Oct 7, 2024
@andrewazores
Copy link
Member Author

@Josh-Matsuoka want to take a stab at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants