Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(agent): add Agent itest #759

Merged
merged 3 commits into from
Feb 25, 2025
Merged

test(agent): add Agent itest #759

merged 3 commits into from
Feb 25, 2025

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Dec 24, 2024 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #42
Depends on #767

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores
Copy link
Member Author

/build_test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Dec 24, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Dec 24, 2024
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 12/24/2024, 4:02:42 PM. View Actions Run.

@github-actions GitHub Actions
Copy link

No OpenAPI schema changes detected.

@github-actions GitHub Actions
Copy link

No GraphQL schema changes detected.

@github-actions GitHub Actions
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/12486156885

2 similar comments
@github-actions GitHub Actions
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/12486156885

@github-actions GitHub Actions
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/12486156885

@andrewazores
Copy link
Member Author

The test runs fine locally in isolation, ie with -Dit.test=AgentDiscoveryIT, but the test setup fails when all tests are run together. For some reason, the localstack container (S3) doesn't get restarted successfully.

@andrewazores
Copy link
Member Author

andrewazores commented Jan 2, 2025 •
edited
Loading

Very strange. I had a hunch that the Broken pipe appearing in the logs was actually about the testcontainers client failing to communicate with the rootless Podman service since it consistently appears right at the time when the container should be created/started. I wasn't able to get much further with that on its own, however, I tried setting up a VM (Ubuntu 24.04 LTS) with Docker rather than Podman, and then running this PR's ./mvnw verify on that system. That worked completely fine. I also tried to create a smaller reproducer for this issue on my main system (rootless Podman) but the reproducer is able to launch the testcontainers test resources just fine.

This was referenced Jan 2, 2025
Merged
Merged
@andrewazores andrewazores marked this pull request as ready for review January 6, 2025 18:49
@andrewazores andrewazores requested a review from a team as a code owner January 6, 2025 18:49
@mergify mergify bot mentioned this pull request Jan 7, 2025
Merged
7 tasks
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 2/13/2025, 4:32:26 PM. View Actions Run.

@github-actions GitHub Actions
Copy link

No GraphQL schema changes detected.

@github-actions GitHub Actions
Copy link

No OpenAPI schema changes detected.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/13317480172

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 2/25/2025, 11:47:19 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

No GraphQL schema changes detected.

@github-actions GitHub Actions
Copy link

No OpenAPI schema changes detected.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/13526431973

@andrewazores andrewazores merged commit 05e2545 into cryostatio:main Feb 25, 2025
9 checks passed
@andrewazores andrewazores deleted the agent-itest branch February 25, 2025 17:02
@andrewazores andrewazores mentioned this pull request Feb 25, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe-to-test test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewazores