fix(discovery): check container discovery domain socket readability before start #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
Workflow started at 1/22/2024, 11:07:38 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
…ility before start
andrewazores
force-pushed
the
container-discovery-warning
branch
from
14723a6 to
e52d2a4
Compare
|
Had a minor conflict in |
|
/build_test |
|
Workflow started at 1/22/2024, 3:04:16 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #250
How to manually test:
./mvnw clean verify ; podman image prune -f./smoketest.bash -Oand look for messages likeERROR: io.cryostat.discovery.DockerDiscovery_Subclass enabled but socket /var/run/docker.sock is not accessible!shortly after startup. The repeated log messages like in [Bug] Built-in container discovery mechanisms repeatedly print messages when enabled but domain socket is not available #250 should no longer appear. May be easier viapodman logs compose_cryostat_1rather than the interleaved smoketest logs from all services.