Cantina #8: gas improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretzke
added a commit
that referenced
this pull request
Sep 29, 2024
* remove unused variable * Safe transfer funds out of pocket (#8) * Fix decimal issues (#9) * pre-compute roles and divisor and remove public functions * remove old todos * Cantina #13: Nits (#11) * remove unused imports * use relative imports * remove dead code * remove redundant line of code * add a zero check to functions * add check whether pocket exists * Cantina #8: gas improvements (#10) * use calldata instead of memory * mark assembly block as memory safe * approve once in initializer * more nits (#12) * use calldata instead of memory * mark assembly block as memory safe * approve once in initializer * Add external takeFee function * Make functions external * remove deployer dependency * update interest rate calculation after liquidation * implement share decimals to mitigate inflation attacks * add token checklist * Cantina: Aave fixes (#13) * add div 0 check to balance of * use supply instead of deprecated deposit function * determine overlying token automatically * consistent balanceOf and totalBalance implementation between base and Aave pocket * assert that the actual amount withdrawn is the amount requested to withdraw * check for staleness while minting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.