Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more accurate words in some french wordings (#408) #409

Closed
wants to merge 1 commit into from
Closed

Use more accurate words in some french wordings (#408) #409

wants to merge 1 commit into from

Conversation

pylapp
Copy link

@pylapp pylapp commented Feb 24, 2025

Some french wordings can be improved to use more accurate words

Closes #408

@pylapp
fix(l10n) french wordings (cryptomator#408)
5037f7b 
Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pylapp pylapp mentioned this pull request Feb 24, 2025
Open
2 tasks
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2025

Walkthrough

The changes modify several French-localized user interface strings for the Cryptomator application. The onboarding information text now uses the term "chiffre" instead of "crypte" to describe data encryption. In addition, the footer concerning biometric unlock has been updated to reference "trousseau iOS" rather than "porte-clés iOS," ensuring that the proper term for the iOS keychain is used. Finally, the footer message for the vault’s keep-unlocked feature has been altered, replacing "terminé par l'application Fichiers" with "déconnecté par l'application Fichiers" to more precisely describe the condition that triggers the requirement to re-unlock the vault. These modifications affect strings identified as "onboarding.info", "vaultDetail.disabledBiometricalUnlock.footer", and "vaultDetail.keepUnlocked.footer.off".

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ceb5eae and 5037f7b.

📒 Files selected for processing (1)
  • SharedResources/fr.lproj/Localizable.strings (2 hunks)
🔇 Additional comments (3)
SharedResources/fr.lproj/Localizable.strings (3)

162-162: LGTM! More accurate encryption terminology.

The change from "crypte" to "chiffre" is linguistically more precise, as "chiffrer" is the correct technical term for encryption in French.

274-274: LGTM! Correct iOS system terminology.

The change from "porte-clés iOS" to "trousseau iOS" aligns with Apple's official French localization for "iOS keychain".

279-279: LGTM! Clearer description of the Files app action.

The change from "terminé" to "déconnecté" better describes the specific action that triggers the need to unlock the vault again.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pylapp
Copy link
Author

pylapp commented Feb 24, 2025

@tobihagemann I signed the CLA (and also provide the fix siwth a signed-off commit).
If you have any question about the french wording I updated, feelf ree to contact me (I am french-native)?
Thank your for you and your team work!

@pylapp pylapp changed the title Fix french wordings (#408) Use more accurate words in some french wordings (#408) Feb 24, 2025
@tobihagemann
Copy link
Member

Thank you for your contribution! However, I won't be able to merge this, because our translations are managed by Crowdin. Translations have to go through this translation platform: https://translate.cryptomator.org/

Crowdin then automatically creates commits and PRs in this project. Unfortunately, this is a one-way street, so we can't sync changes from this project back to Crowdin.

If possible, please head over to Crowdin and make the changes there. Thank you and sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to improve some french wordings
3 participants
@pylapp @CLAassistant @tobihagemann