Merge pull request #3 from cskiwi/fix/enabling-fetch

fix: enable fetch

Author: cskiwi

.changeset/fast-taxis-begin.md

@@ -0,0 +1,5 @@
+---
+"@fake-scope/fake-pkg": patch
+---
+
+fix: enable fetch

.github/workflows/ci.yml

@@ -22,14 +22,17 @@ jobs:
         with:
           bun-version: latest
 
-      # Connect your workspace on nx.app and uncomment this to enable task distribution.
-      # The "--stop-agents-after" is optional, but allows idle agents to shut down once the "e2e-ci" targets have been requested
-      # - run: bunx nx-cloud start-ci-run --distribute-on="5 linux-medium-js" --stop-agents-after="e2e-ci"
-
       - run: bun install --no-cache
       - uses: nrwl/nx-set-shas@v4
 
-      # Prepend any command with "nx-cloud record --" to record its logs to Nx Cloud
-      # - run: bun nx-cloud record -- echo Hello World
+      - name: Install Playwright Browsers
+        run: npx playwright install --with-deps
+
       - run: bun nx affected -t lint test build
       - run: bun nx affected --parallel 1 -t e2e-ci
+      - uses: actions/upload-artifact@v4
+        if: ${{ !cancelled() }}
+        with:
+          name: playwright-report
+          path: playwright-report/
+          retention-days: 30

apps/app-e2e/playwright.config.ts

@@ -25,7 +25,7 @@ export default defineConfig({
   },
   /* Run your local dev server before starting the tests */
   webServer: {
-    command: 'bun nx serve app',
+    command: 'bun start',
     url: 'http://localhost:4200',
     reuseExistingServer: !process.env['CI'],
     cwd: workspaceRoot,

apps/app/src/main.server.ts

@@ -1,6 +1,6 @@
 import { bootstrapApplication } from '@angular/platform-browser';
-import { AppComponent, config } from '@app/frontend-root';
+import { RootComponent, config } from '@app/frontend-root';
 
-const bootstrap = () => bootstrapApplication(AppComponent, config);
+const bootstrap = () => bootstrapApplication(RootComponent, config);
 
 export default bootstrap;

apps/app/src/main.ts

@@ -1,6 +1,6 @@
 import { bootstrapApplication } from '@angular/platform-browser';
-import { AppComponent, appConfig } from '@app/frontend-root';
+import { RootComponent, appConfig } from '@app/frontend-root';
 
-bootstrapApplication(AppComponent, appConfig).catch((err) =>
+bootstrapApplication(RootComponent, appConfig).catch((err) =>
   console.error(err)
 );

bun.lockb

@@ -2,7 +2,9 @@
   "name": "@backend/test",
   "version": "0.0.1",
   "dependencies": {
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "@nestjs/common": "^10.3.8",
+    "express": "~4.19.2"
   },
   "type": "commonjs",
   "main": "./src/index.js",

libs/backend/test/package.json

@@ -3,14 +3,14 @@ import { provideRouter } from '@angular/router';
 import { appRoutes } from './app.routes';
 import { provideClientHydration } from '@angular/platform-browser';
 import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
-import { provideHttpClient } from '@angular/common/http';
+import { provideHttpClient, withFetch } from '@angular/common/http';
 
 export const appConfig: ApplicationConfig = {
   providers: [
     provideClientHydration(),
     provideZoneChangeDetection({ eventCoalescing: true }),
     provideRouter(appRoutes),
     provideAnimationsAsync(),
-    provideHttpClient(),
+    provideHttpClient(withFetch()),
   ],
 };

libs/frontend/root/src/app.component.html

@@ -0,0 +1,3 @@
+export * from './app.routes';
+export * from './app.config';
+export * from './app.config.server';

libs/frontend/root/src/app.component.spec.ts

@@ -1,4 +1,2 @@
-export * from './app.component';
-export * from './app.routes';
-export * from './app.config';
-export * from './app.config.server';
+export * from './root';
+export * from './config';

libs/frontend/root/src/app.config.server.ts renamed to libs/frontend/root/src/config/app.config.server.ts

@@ -0,0 +1 @@
+export * from './root.component';

libs/frontend/root/src/app.config.ts renamed to libs/frontend/root/src/config/app.config.ts

@@ -0,0 +1,5 @@
+<h1>Welcome app</h1>
+
+<pre>{{ movie() | json }}</pre>
+
+<router-outlet></router-outlet>

libs/frontend/root/src/app.routes.ts renamed to libs/frontend/root/src/config/app.routes.ts

@@ -0,0 +1,19 @@
+import { provideHttpClient } from '@angular/common/http';
+import { TestBed } from '@angular/core/testing';
+import { RootComponent } from './root.component';
+
+describe('RootComponent', () => {
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      providers: [provideHttpClient()],
+      imports: [RootComponent],
+    }).compileComponents();
+  });
+
+  it('should render title', () => {
+    const fixture = TestBed.createComponent(RootComponent);
+    fixture.detectChanges();
+    const compiled = fixture.nativeElement as HTMLElement;
+    expect(compiled.querySelector('h1')?.textContent).toContain('Welcome app');
+  });
+});

libs/frontend/root/src/config/index.ts

@@ -1,5 +1,5 @@
 import { JsonPipe } from '@angular/common';
-import { HttpClient, provideHttpClient } from '@angular/common/http';
+import { HttpClient } from '@angular/common/http';
 import { Component, inject } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { derivedAsync } from 'ngxtension/derived-async';
@@ -8,10 +8,10 @@ import { derivedAsync } from 'ngxtension/derived-async';
   standalone: true,
   imports: [RouterModule, JsonPipe],
   selector: 'app-root',
-  templateUrl: './app.component.html',
-  styleUrl: './app.component.scss',
+  templateUrl: './root.component.html',
+  styleUrl: './root.component.scss',
 })
-export class AppComponent {
+export class RootComponent {
   private readonly httpClient = inject(HttpClient);
   movie = derivedAsync(() => this.httpClient.get(`/api/backend-test`));
 }

libs/frontend/root/src/index.ts

@@ -1,6 +1,6 @@
 {
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
-  "defaultBase": "master",
+  "defaultBase": "main",
   "defaultProject": "app",
   "namedInputs": {
     "default": ["{projectRoot}/**/*", "sharedGlobals"],

libs/frontend/root/src/root/index.ts

@@ -37,9 +37,9 @@
     "@angular-devkit/build-angular": "~18.0.1",
     "@angular-devkit/core": "~18.0.1",
     "@angular-devkit/schematics": "~18.0.1",
-    "@angular-eslint/eslint-plugin": "~17.5.1",
-    "@angular-eslint/eslint-plugin-template": "~17.5.1",
-    "@angular-eslint/template-parser": "~17.5.1",
+    "@angular-eslint/eslint-plugin": "rc-v18",
+    "@angular-eslint/eslint-plugin-template": "rc-v18",
+    "@angular-eslint/template-parser": "rc-v18",
     "@angular/cli": "~18.0.1",
     "@angular/compiler-cli": "~18.0.0",
     "@angular/language-service": "~18.0.0",