fix: allow file config to override true default values

This allows a "false" boolean value to override a "true" default value when loading the options via the elastic-apm-node.js config file Fixes: elastic#4112 Closes: elastic#4112
csnate · Jul 2, 2024 · b04fd1f · b04fd1f
1 parent 8472afa
commit b04fd1f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lib/config/schema.js b/lib/config/schema.js
@@ -876,7 +876,7 @@ CONFIG_SCHEMA.forEach((def) => {
   if (def.envVar && process.env[def.envVar]) {
     def.environmentValue = process.env[def.envVar];
     def.source = 'environment';
-  } else if (fileOpts && fileOpts[def.name]) {
+  } else if (fileOpts && typeof fileOpts[def.name] !== 'undefined') {
     def.fileValue = fileOpts[def.name];
     def.source = 'file';
   }

diff --git a/test/start/file/elastic-apm-node.js b/test/start/file/elastic-apm-node.js
@@ -7,5 +7,6 @@
 'use strict'
 
 module.exports = {
-  serviceName: 'from-file'
+  serviceName: 'from-file',
+  active: false
 }
diff --git a/test/start/file/test.test.js b/test/start/file/test.test.js
@@ -19,5 +19,7 @@ const tape = require('tape');
 
 tape('from-file serviceName test', function (t) {
   t.equals(agent._conf.serviceName, 'from-file');
+  t.equals(agent._conf.active, false);
+  t.equals(agent._conf.captureBody, 'off'); // Existing default
   t.end();
 });