Merge pull request #10 from deanagan/master

Added tests and fixes for type hierarchy

Author: deanagan

fluentcheck/assertions/types.py

@@ -12,10 +12,10 @@ def is_subtype_of(check_obj, _type):
 
 def is_not_subtype_of(check_obj, _type):
     try:
-        assert issubclass(check_obj._val.__class__, _type)
-        raise CheckError('{} is subtype of {}'.format(check_obj._val, _type))
-    except AssertionError:
+        assert not issubclass(check_obj._val.__class__, _type)
         return check_obj
+    except AssertionError:
+        raise CheckError('{} is subtype of {}'.format(check_obj._val, _type))
 
 
 def is_of_type(check_obj, _type):

fluentcheck/tests/test_type_hierarchy.py

@@ -0,0 +1,78 @@
+import unittest
+from fluentcheck.check import Check, CheckError
+
+class ParentA:
+    def __init__(self):
+        pass
+
+class Child(ParentA):
+    def __init__(self):
+        pass
+
+class GrandChild(Child):
+    def __init__(self):
+        pass
+
+class ParentB:
+    def __init__(self):
+        pass
+
+class ChildOfMultipleParents(ParentA, ParentB):
+    def __init__(self):
+        pass
+
+class TestTypeHierarchy(unittest.TestCase):
+
+    def test_is_subtype_of(self):
+        res = Check(Child()).is_subtype_of(ParentA)
+        self.assertIsInstance(res, Check)
+        try:
+            Check(ParentA()).is_subtype_of(Child)
+            self.fail()
+        except CheckError:
+            pass
+
+    def test_is_subtype_of_when_grandchild_is_subtype_of_parent(self):
+        res = Check(GrandChild()).is_subtype_of(ParentA)
+        self.assertIsInstance(res, Check)
+        try:
+            Check(ParentA()).is_subtype_of(GrandChild)
+            self.fail()
+        except CheckError:
+            pass
+    
+    def test_is_subtype_of_when_multiple_inheritance(self):
+        res = Check(ChildOfMultipleParents()).is_subtype_of((ParentA, ParentB))
+        self.assertIsInstance(res, Check)
+        try:
+            Check(ParentA()).is_subtype_of((ChildOfMultipleParents, ParentB))
+            self.fail()
+        except CheckError:
+            pass
+
+    def test_is_not_subtype_of(self):
+        res = Check(ParentA()).is_not_subtype_of(ParentB)
+        self.assertIsInstance(res, Check)
+        try:
+            Check(Child()).is_not_subtype_of(ParentA)
+            self.fail()
+        except CheckError:
+            pass
+    
+    def test_is_subtype_of_itself(self):
+        res = Check(Child()).is_subtype_of(Child)
+        self.assertIsInstance(res, Check)
+        try:
+            Check(Child()).is_not_subtype_of(Child)
+            self.fail()
+        except CheckError:
+            pass
+    
+    def test_is_subtype_of_atleast_one_parent(self):
+        res = Check(Child()).is_subtype_of((ParentA, ParentB))
+        self.assertIsInstance(res, Check)
+        try:
+            Check(Child()).is_not_subtype_of((ParentA, ParentB))
+            self.fail()
+        except CheckError:
+            pass