Skip to content

Commit 89ea6ed

Browse files
committedJun 30, 2015
[fixed] Add missed propType validation for Button 'type' property
1 parent 557e470 commit 89ea6ed

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed
 

‎src/Button.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from 'react';
22
import classNames from 'classnames';
33
import BootstrapMixin from './BootstrapMixin';
44
import CustomPropTypes from './utils/CustomPropTypes';
5+
import ButtonInput from './ButtonInput';
56

67
const Button = React.createClass({
78
mixins: [BootstrapMixin],
@@ -14,14 +15,18 @@ const Button = React.createClass({
1415
navDropdown: React.PropTypes.bool,
1516
componentClass: CustomPropTypes.elementType,
1617
href: React.PropTypes.string,
17-
target: React.PropTypes.string
18+
target: React.PropTypes.string,
19+
/**
20+
* Defines HTML button type Attribute
21+
* @type {("button"|"reset"|"submit")}
22+
*/
23+
type: React.PropTypes.oneOf(ButtonInput.types)
1824
},
1925

2026
getDefaultProps() {
2127
return {
2228
bsClass: 'button',
23-
bsStyle: 'default',
24-
type: 'button'
29+
bsStyle: 'default'
2530
};
2631
},
2732

@@ -68,6 +73,7 @@ const Button = React.createClass({
6873
return (
6974
<Component
7075
{...this.props}
76+
type={this.props.type || 'button'}
7177
className={classNames(this.props.className, classes)}>
7278
{this.props.children}
7379
</Component>

0 commit comments

Comments
 (0)