Skip to content

Including 'ready-to-show' function to open #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Including 'ready-to-show' function to open #4

wants to merge 1 commit into from

Conversation

BigBallard
Copy link

You are missing the 'ready-to-show' hook. Without it, the process starts but the windows will not open since it is never told to do so.

You are missing the 'ready-to-show' hook. Without it, the process starts but the windows will not open since it is never told to do so.
@jreznot
Copy link
Contributor

jreznot commented Oct 26, 2018

It works on all the platforms even without this callback

@BigBallard
Copy link
Author

It didnt with mine. The window never showed when running gradle assemble jettyStart but it did when adding the pr code. And this is with:
Java 8
Gradle 5.0.0 RC1
Electron 2.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants