Clean up test for id checking

Author: luke-hill

compatibility/support/shared_examples.rb

@@ -29,16 +29,13 @@
   end
 
   it 'ensures a consistent `testRunStartedId` across the entire test run' do
-    # Step 1) Grab testRunStarted[:id]
-    test_run_message = parsed_generated.detect { |msg| message_type(msg) == :test_run_started }
-    id = test_run_message.test_run_started.id
-    
-    # Step 2) Validate every testCase has a [:testRunStartedId] equal to the above
-    # Step 3) Validate the single testRunFinished [:testRunStartedId] equal to the above
-    messages_types_containing_test_run_started_id = %i[test_case test_run_finished]
-    messages_containing_test_run_started_id = parsed_generated.select { |msg| messages_types_containing_test_run_started_id.include?(message_type(msg)) }
+    test_run_started_id = parsed_generated.detect { |msg| message_type(msg) == :test_run_started }.test_run_started.id
+    messages_containing_test_run_started_id = parsed_generated.select do |msg|
+      # These two types of message are the only ones containing the testRunStartedId attribute
+      %i[test_case test_run_finished].include?(message_type(msg))
+    end
     ids = messages_containing_test_run_started_id.map { |msg| msg.send(message_type(msg)).test_run_started_id }
 
-    expect(ids).to all eq(id)
+    expect(ids).to all eq(test_run_started_id)
   end
 end