V10: Update dependencies #1782
Open
V10: Update dependencies #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htly update rubocop gems
davidjgoss
reviewed
Mar 13, 2025
| message = Cucumber::Messages::Envelope.new( | ||
| test_run_started: Cucumber::Messages::TestRunStarted.new( | ||
| timestamp: time_to_timestamp(Time.now) | ||
| timestamp: time_to_timestamp(Time.now), | ||
| id: event.test_cases.first.id |
There was a problem hiding this comment.
The id on a TestRunStarted should be a generated id that represents the entire test run - it doesn't pertain to any particular test case or attempt. The same value should then go on TestRunFinished.testRunStartedId at the end.
nodeg
reviewed
Mar 13, 2025
… during the test run started event
Change order of broadcast such that test case ready comes after test run started
Rename phase to type for type of hook Add hook type to envelope creation Ensure enum conversion is adherent to message enum validation (Around hook is the outlier here - InstallPlugin can be converted adherently)
|
For anyone monitoring. CCK conformance (To target v17), is about 90% complete now. We are having issues with 1 last CCK spec (retry). Once we have CCK v17 compliance, the remaining items are just refactors and some tidy ups. That then is the last blocker for v10 being released. |
luke-hill
commented
May 16, 2025
lib/cucumber/runtime.rb
Outdated
| unless configuration.dry_run? | ||
| filters << Filters::BroadcastTestRunStartedEvent.new(@configuration) | ||
| filters << Filters::Quit.new | ||
| filters << Filters::Retry.new(@configuration) | ||
| # need to do this last so it becomes the first test step | ||
| filters << Filters::PrepareWorld.new(self) | ||
| end | ||
|
|
||
| filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration) |
There was a problem hiding this comment.
Note to self (cc/ @davidjgoss )
This is the cause of the retry CCK blowing up
|
Truffleruby issue: oracle/truffleruby#3870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update dependencies for the final time - Needed for v10 release
Checklist for completion
9.1or JRuby natural updates)Type of change
Please delete options that are not relevant.
work as expected)
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses