-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
V10: Update dependencies #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luke-hill
wants to merge
38
commits into
main
Choose a base branch
from
refactor/unrestrict_deps_for_v10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V10: Update dependencies #1782
Changes from 6 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
3120dc1
Unrestrict runtime deps
luke-hill 0fac6b5
Remove rubocop-capybara as its no longer needed or suggested and slig…
luke-hill b91f20c
Slight tidy to interceptor spec
luke-hill 4129214
Update CCK testing version
luke-hill 583b9ca
Downgrade CCK to v17 whilst investigating issues
luke-hill 90c9233
WIP for adding id to test run id
luke-hill 3475155
Merge branch 'main' into refactor/unrestrict_deps_for_v10
luke-hill 8e89a56
Fix duplicate testing block
luke-hill 64798de
Run release pipeline tests on 3.4 also
luke-hill 244bc1b
Update docs
luke-hill 4258906
Minor simplification to main runtime
luke-hill 0857499
Fix bug with deprecator message
luke-hill 21fea7a
Fix deprecator spec
luke-hill bdb9be1
Minor tidy to backtrace filter
luke-hill a033db0
Change ID generation to be much simpler - Add this to output envelope…
luke-hill 392292f
Remove redundant input event when finding / generating test run id
luke-hill 3ecca70
Add Test run ID to test case ready event
luke-hill 6d38517
Add test run started id to testrunfinished message
luke-hill b783edb
Hook refactors
luke-hill 4b6a5b4
Downgrade CCK back to 16.2 and hardcode cck tests to just retry
luke-hill 88ea676
Recommit v17 of CCK
luke-hill 9a2bc8e
Experiment move TestCaseReadyEvent lower down
luke-hill cf3d717
Re-run all CCK tests again;
luke-hill 9f0ba59
Change to CCK steps for v18 conformance
luke-hill fc670f9
Update to v18 of cck
luke-hill ec79d5f
Triage one failing test
luke-hill e7ae78a
Bugfix wrong media type
luke-hill deae018
Add in deprecated steps for CCK conformance (currently)
luke-hill 59d450b
Add in truffleruby guard for some tests
luke-hill 8e7f9e8
Hard code the truffleruby test to use v24
luke-hill 9027061
Add truffleruby 24 into release pipeline
luke-hill cfc7e86
Fix rubocop
luke-hill b70c543
Compress a few lines down
luke-hill 62a8fa4
Re-test the whole of the CCK again
luke-hill a38c2d9
Clarify deprecation notice for CCK attachment steps
luke-hill 5b56ad6
Remove redundant require for testrunstarted query
luke-hill bb99b55
Fix missing arg in step
luke-hill 87d439f
Tidy up of lines / style
luke-hill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ def initialize(config) | |
@pickle_step_by_test_step = Query::PickleStepByTestStep.new(config) | ||
@step_definitions_by_test_step = Query::StepDefinitionsByTestStep.new(config) | ||
@test_case_started_by_test_case = Query::TestCaseStartedByTestCase.new(config) | ||
@test_run_started = Query::TestRunStarted.new(config) | ||
|
||
config.on_event :envelope, &method(:on_envelope) | ||
config.on_event :gherkin_source_read, &method(:on_gherkin_source_read) | ||
|
@@ -34,6 +35,7 @@ def initialize(config) | |
config.on_event :undefined_parameter_type, &method(:on_undefined_parameter_type) | ||
|
||
@test_case_by_step_id = {} | ||
@current_test_run_started_id = nil | ||
@current_test_case_started_id = nil | ||
@current_test_step_id = nil | ||
end | ||
|
@@ -149,10 +151,13 @@ def parameter_type_name(step_match_argument) | |
step_match_argument.parameter_type&.name if step_match_argument.respond_to?(:parameter_type) | ||
end | ||
|
||
def on_test_run_started(*) | ||
def on_test_run_started(event) | ||
@current_test_run_started_id = test_case_started_id(event.test_case) | ||
|
||
message = Cucumber::Messages::Envelope.new( | ||
test_run_started: Cucumber::Messages::TestRunStarted.new( | ||
timestamp: time_to_timestamp(Time.now) | ||
timestamp: time_to_timestamp(Time.now), | ||
id: event.test_cases.first.id | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
) | ||
) | ||
|
||
|
@@ -266,6 +271,10 @@ def on_undefined_parameter_type(event) | |
def test_case_started_id(test_case) | ||
@test_case_started_by_test_case.test_case_started_id_by_test_case(test_case) | ||
end | ||
|
||
def test_run_started_id(test_case) | ||
@test_run_started.test_run_id(test_case) | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'cucumber/formatter/errors' | ||
|
||
module Cucumber | ||
module Formatter | ||
module Query | ||
class TestRunStarted | ||
def initialize(config) | ||
@test_run_ids = {} | ||
config.on_event :test_run_started, &method(:on_test_run_started) | ||
end | ||
|
||
def test_run_id(test_case) | ||
return @test_run_ids[test_case.id] if @test_run_ids.key?(test_case.id) | ||
|
||
raise TestCaseUnknownError, "No pickle found for #{test_case.id} }. Known: #{@test_run_ids.keys}" | ||
end | ||
|
||
private | ||
|
||
def on_test_run_started(event) | ||
@test_run_ids[event.test_case.id] = event.pickle.id | ||
end | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.