From ab5b9998a783792afd26fbdb46c57c5617612814 Mon Sep 17 00:00:00 2001
From: erik r <er2576@columbia.edu>
Date: Wed, 2 Mar 2022 14:17:35 -0500
Subject: [PATCH] improves accessibility issues. closes HOURS-105

---
 app/views/layouts/_topnavbar.html.erb | 16 ++++++++--------
 app/views/layouts/admin.html.erb      |  2 +-
 app/views/layouts/error.html.erb      |  2 +-
 app/views/layouts/mailer.html.erb     |  2 +-
 app/views/layouts/public.html.erb     |  2 +-
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/app/views/layouts/_topnavbar.html.erb b/app/views/layouts/_topnavbar.html.erb
index 3d4dbd8..f9a6037 100644
--- a/app/views/layouts/_topnavbar.html.erb
+++ b/app/views/layouts/_topnavbar.html.erb
@@ -64,10 +64,10 @@
 										 </div>
 								 </li>
 								 <li class="nav-item dropdown position-static">
-										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown4" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown2" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
 												 Libraries
 										 </a>
-										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown4">
+										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown2">
 												 <div class="container d-block">
 														 <div class="row">
 																 <div class="col">
@@ -96,10 +96,10 @@
 										 </div>
 								 </li>
 								 <li class="nav-item dropdown position-static">
-										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown2" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown3" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
 												 Using<span class="d-inline d-sm-none d-md-inline"> the Libraries</span>
 										 </a>
-										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown2">
+										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown3">
 												 <div class="container d-block">
 														 <div class="row">
 																 <div class="col">
@@ -121,10 +121,10 @@
 										 </div>
 								 </li>
 								 <li class="nav-item dropdown position-static">
-										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown3" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown4" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
 												 Collections
 										 </a>
-										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown3">
+										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown4">
 												 <div class="container d-block">
 														 <div class="row">
 																 <div class="col">
@@ -145,10 +145,10 @@
 										 </div>
 								 </li>
 								 <li class="nav-item dropdown position-static">
-										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown4" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+										 <a class="nav-link dropdown-toggle" href="#" id="navbarDropdown5" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
 												 About
 										 </a>
-										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown4">
+										 <div class="dropdown-menu bg-secondary w-100 border-top-0 border-left-0 border-right-0 rounded-0 mt-0" aria-labelledby="navbarDropdown5">
 												 <div class="container d-block">
 														 <div class="row">
 																 <div class="col">
diff --git a/app/views/layouts/admin.html.erb b/app/views/layouts/admin.html.erb
index f0fd662..a9c7aaf 100644
--- a/app/views/layouts/admin.html.erb
+++ b/app/views/layouts/admin.html.erb
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <title>Columbia University Libraries | Location Hours</title>
     <meta charset="utf-8">
diff --git a/app/views/layouts/error.html.erb b/app/views/layouts/error.html.erb
index 5e4f11b..bd963dc 100644
--- a/app/views/layouts/error.html.erb
+++ b/app/views/layouts/error.html.erb
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <title>Columbia University Libraries | Location Hours</title>
     <meta charset="utf-8">
diff --git a/app/views/layouts/mailer.html.erb b/app/views/layouts/mailer.html.erb
index cbd34d2..f96164b 100644
--- a/app/views/layouts/mailer.html.erb
+++ b/app/views/layouts/mailer.html.erb
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <style>
diff --git a/app/views/layouts/public.html.erb b/app/views/layouts/public.html.erb
index 7f278c4..da216c0 100644
--- a/app/views/layouts/public.html.erb
+++ b/app/views/layouts/public.html.erb
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
     <title><%= page_title(@location) %> | Columbia University Libraries</title>
     <meta charset="utf-8">