WinForms: Fix ampersands in profiles toolbar

#471
cyanfish · Feb 2, 2025 · 2e34c4e · 2e34c4e
1 parent 8e14a8a
commit 2e34c4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/NAPS2.Lib.WinForms/EtoForms/Ui/WinFormsDesktopForm.cs b/NAPS2.Lib.WinForms/EtoForms/Ui/WinFormsDesktopForm.cs
@@ -212,9 +212,10 @@ protected override void UpdateProfilesToolbar()
             var profile = profiles[i];
             var item = toolbarItems[i];
             item.Tag = profile;
-            if (item.Text != profile.DisplayName)
+            var text = profile.DisplayName.Replace("&", "&&");
+            if (item.Text != text)
             {
-                item.Text = profile.DisplayName;
+                item.Text = text;
             }
         }
     }

diff --git a/NAPS2.Lib/EtoForms/Ui/DesktopForm.cs b/NAPS2.Lib/EtoForms/Ui/DesktopForm.cs
@@ -541,7 +541,6 @@ private void UpdateScanButton()
         var commandList = _profileManager.Profiles.Select(profile =>
                 new ActionCommand(() => _desktopScanController.ScanWithProfile(profile))
                 {
-                    // TODO: Does this need to change on non-WinForms?
                     MenuText = profile.DisplayName.Replace("&", "&&"),
                     IconName = profile == defaultProfile ? "accept_small" : null
                 })