Added UIScrollViewDelegate modifier to WebView #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the SwiftUI container / caller to set the WKWebView.scrollView.delegate with the modifier scrollViewDelegate(_:).
|
@rbenjamin Thank you for creating the pull request. Please make the following changes:
After adding the tests, please verify that the existing implementation (allowsScrollViewBounces and refreshable()) is not negatively impacted. |
… WKWebView.stopLoading(). Added Tests to WebViewProxyTests corresponding to stopLoading implementation, along with corresponding function in Mock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a modifier to WebView to support UIScrollViewDelegate. I'm implementing WebUI with a custom toolbar and wanted to ensure the toolbar view hides when the user scrolls down and appears when they scroll up. This is my first contribution to someone else's project -- hope I got it right!
Allows the SwiftUI container / caller to set the WKWebView.scrollView.delegate with the modifier scrollViewDelegate(_:).