-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new plugins in the list #6126
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
Regarding your submission for the plugin cypress-xporter, please review the requirements listed under Adding Plugins:
In addition you should ensure that your package.json includes the key repository so that it is possible for users to report issues. Executing the following should be successful and not result in an error message:
The link to your source code repository is also the one needed in the plugins list It would also be clearer for the git history if you change the title of this PR to include the name of your plugin cc: @dingraham |
I suggest also to add the bugs field to your package-json. Currently if you execute npm bugs cypress-xporter it opens only https://www.npmjs.com/package/cypress-xporter and there is no way there to enter any bug report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have asked for review again. There are still open points in the comments above.
I suggest that you set bugs
to
https://github.com/kabirfaisal1/cypress-reporter/issues
Take a look at other plugins to see how they have set up their package.json
Hi @MikeMcC399 |
I suggest you add also the package-json fields
If you compare your plugin to others, you will see that this is common practice. Currently there is no repository shown on https://www.npmjs.com/package/cypress-xporter As mentioned above, I don't see the following points addressed at the moment:
|
Here is an example from https://github.com/cypress-io/github-action/blob/master/package.json "repository": {
"type": "git",
"url": "git+https://github.com/cypress-io/github-action.git"
},
"keywords": [
"actions",
"cypress-io"
],
"author": "Cypress-io",
"license": "MIT",
"bugs": {
"url": "https://github.com/cypress-io/github-action/issues"
},
"homepage": "https://github.com/cypress-io/github-action#readme", |
The requirements in https://github.com/cypress-io/cypress-documentation/blob/main/CONTRIBUTING.md#adding-plugins have been updated to include the Please let us know if you intend to address the outstanding comments. |
I added a new plug that I created in to the plugins.js