chore: update win.cookie calls to win.document.cookie call in test #31527
Conversation
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix-win-cookie-in-tests
|
| Run status |
|
| Run duration | 18m 24s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
77
|
Skipped
|
0
|
Passing
|
5624
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
| return !cookie || cookie === '__cypress.initial=true' | ||
| }) | ||
|
|
||
| win.document.cookie = 'key=value' |
There was a problem hiding this comment.
This test doesn't pass if you pass the SameSite=Strict; Secure; Path=/fixtures to this cookie. I'm not sure if this is some kind of bug, but that's the only way to get it to pass atm.
There was a problem hiding this comment.
something like this though I think fundamentally changes the test. I can look at it tomorrow?
There was a problem hiding this comment.
Well, it wasn’t really testing anything to begin with. :/
There was a problem hiding this comment.
yeah win.cookie really isn't anything 😂 . Even if it was document.cookie that wouldn't even be set in the first place because its not even at that path, so it will not set it and no-op. I think this change is fine.
| return !cookie || cookie === '__cypress.initial=true' | ||
| }) | ||
|
|
||
| win.document.cookie = 'key=value' |
There was a problem hiding this comment.
something like this though I think fundamentally changes the test. I can look at it tomorrow?
| return !cookie || cookie === '__cypress.initial=true' | ||
| }) | ||
|
|
||
| win.document.cookie = 'key=value' |
There was a problem hiding this comment.
yeah win.cookie really isn't anything 😂 . Even if it was document.cookie that wouldn't even be set in the first place because its not even at that path, so it will not set it and no-op. I think this change is fine.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Remove
ts-expect-errorwhere we were callingwin.cookieinstead ofwin.document.cookie.win.cookiedoes not exist, but the test was calling and testing this. I updated it towin.document.cookieSteps to test
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?