-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add pre-commit-update and related updates #507
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 94.44% 94.44% -0.01%
==========================================
Files 57 57
Lines 3188 3186 -2
==========================================
- Hits 3011 3009 -2
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely also should be merged after #506
@@ -26,16 +26,17 @@ | |||
"source": [ | |||
"import pathlib\n", | |||
"\n", | |||
"# ignore mix type warnings from pandas\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes linting changes to .ipynb files are wonky and inappropriate. Just double-clicking here to see if these changes are intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this slightly changed some of the formatting but in general the notebook looked sound. I'll do a triple-check here to see if I can run the notebook.
Description
While working on #506 I noticed that I needed to update
actionlint
in order to effectively pass checks bypre-commit
. This made me wonder if there were other updates we could apply withpre-commit-update
. I added that as a check to the pre-commit configuration, then applied the updates. Afterwards I applied changes which helped meet the new standards from the checks within the updated configuration.Should be merged after #505
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.