Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we survived 4.0.0 #70

Closed
blogh opened this issue Oct 7, 2024 · 3 comments
Closed

Check if we survived 4.0.0 #70

blogh opened this issue Oct 7, 2024 · 3 comments

Comments

@blogh
Copy link
Collaborator

blogh commented Oct 7, 2024

https://patroni.readthedocs.io/en/latest/releases.html#version-4-0-0

All master references where changed to primary / leader.

@blogh
Copy link
Collaborator Author

blogh commented Oct 7, 2024

  • on the leader
check_patroni/vagrant on  master [!?] via 🐍 v3.12.6 (.venv) via ⍱ v2.3.4 took 1h1m5s                                                                                       
❯ ./check_patroni.sh http://10.20.30.52:8008                                                                                      
-- Running patroni checks using endpoint http://10.20.30.52:8008                                                                                                             
-- Cluster checks                                                                                                                                                            
CLUSTERCONFIGHASCHANGED OK - The hash of patroni's dynamic configuration has not changed (fe5d97ed3f864d4e3f7baabe6663b482). | is_configuration_changed=0;;@1:1              
CLUSTERHASLEADER OK - The cluster has a running leader. | has_leader=1;;@0 is_leader=1 is_standby_leader=0 is_standby_leader_in_arc_rec=0;@1:1                               
CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2 p1_lag=0 p1_sync=0 p1_timeline=1 p3_lag=0 p3_sync=0 p3_timeline=1 sync_replica=0 unhealthy_replica=0         
CLUSTERISINMAINTENANCE OK - is_in_maintenance is 0 | is_in_maintenance=0;;0                                                                                                  
CLUSTERHASSCHEDULEDACTION OK - has_scheduled_actions is 0 | has_scheduled_actions=0;;0 scheduled_restart=0 scheduled_switchover=0                                            
CLUSTERNODECOUNT OK - members is 3 | healthy_members=3 members=3 role_leader=1 role_replica=2 state_running=1 state_streaming=2                                              
-- Node checks                                                                                                                                                               
NODEISALIVE OK - This node is alive (patroni is running). | is_alive=1;;@0                                                                                                   
NODEISPENDINGRESTART OK - This node doesn't have the pending restart flag. | is_pending_restart=0;;0                                                                         
NODEISPRIMARY OK - This node is the primary with the leader lock. | is_primary=1;;@0                                                                                         
NODEISLEADER CRITICAL - This node is not a standby leader node. | is_leader=0;;@0                                                                                            
NODEISREPLICA CRITICAL - This node is not a running replica with no noloadbalance tag. | is_replica=0;;@0                                                                    
NODEISREPLICA CRITICAL - This node is not a running synchronous replica with no noloadbalance tag. | is_replica=0;;@0                                                        
NODEPATRONIVERSION OK - Patroni's version is 4.0.2. | is_version_ok=1;;@0                                                                                                    
NODETLHASCHANGED OK - The timeline is still 1. | is_timeline_changed=0;;@1:1 timeline=1 
  • on a standby
check_patroni/vagrant on  master [!?] via 🐍 v3.12.6 (.venv) via ⍱ v2.3.4                                                                                                   
❯ ./check_patroni.sh http://10.20.30.53:8008       
-- Running patroni checks using endpoint http://10.20.30.53:8008                                                                                                             
-- Cluster checks                                                                                                                                                            
CLUSTERCONFIGHASCHANGED OK - The hash of patroni's dynamic configuration has not changed (fe5d97ed3f864d4e3f7baabe6663b482). | is_configuration_changed=0;;@1:1              
CLUSTERHASLEADER OK - The cluster has a running leader. | has_leader=1;;@0 is_leader=1 is_standby_leader=0 is_standby_leader_in_arc_rec=0;@1:1                               
CLUSTERHASREPLICA OK - healthy_replica is 2 | healthy_replica=2 p1_lag=0 p1_sync=0 p1_timeline=1 p3_lag=0 p3_sync=0 p3_timeline=1 sync_replica=0 unhealthy_replica=0         
CLUSTERISINMAINTENANCE OK - is_in_maintenance is 0 | is_in_maintenance=0;;0                                                                                                  
CLUSTERHASSCHEDULEDACTION OK - has_scheduled_actions is 0 | has_scheduled_actions=0;;0 scheduled_restart=0 scheduled_switchover=0                                            
CLUSTERNODECOUNT OK - members is 3 | healthy_members=3 members=3 role_leader=1 role_replica=2 state_running=1 state_streaming=2                                              
-- Node checks                                                                                                                                                               
NODEISALIVE OK - This node is alive (patroni is running). | is_alive=1;;@0                                                                                                   
NODEISPENDINGRESTART OK - This node doesn't have the pending restart flag. | is_pending_restart=0;;0                                                                         
NODEISPRIMARY CRITICAL - This node is not the primary with the leader lock. | is_primary=0;;@0                                                                               
NODEISLEADER CRITICAL - This node is not a standby leader node. | is_leader=0;;@0                                                                                            
NODEISREPLICA OK - This node is a running replica with no noloadbalance tag. | is_replica=1;;@0                                                                              
NODEISREPLICA CRITICAL - This node is not a running synchronous replica with no noloadbalance tag. | is_replica=0;;@0                                                        
NODEPATRONIVERSION OK - Patroni's version is 4.0.2. | is_version_ok=1;;@0                                                                                                    
NODETLHASCHANGED OK - The timeline is still 1. | is_timeline_changed=0;;@1:1 timeline=1 

@blogh
Copy link
Collaborator Author

blogh commented Oct 7, 2024

  • Code:
check_patroni on  master [!?] via 🐍 v3.12.6 (.venv) 
❯ grep -R master check_patroni                                                                                                                        
check_patroni/cli.py:    * master or leader
  • Tests :
check_patroni on  patroni_4.0.0 [!?] via 🐍 v3.12.6 (.venv)                                                                                                                 
❯ grep -R master tests/ | grep -v postmaster  
tests/json/cluster_config_has_changed.json:  "master_start_timeout": 300,                                                                                                    
tests/json/node_is_replica_ko.json:  "role": "master",                                                                                                                       
tests/json/node_is_leader_ko.json:  "role": "master",                                                                                                                        
tests/json/cluster_has_replica_patroni_verion_3.1.0.json:  "role": "master",                                                                                                 
tests/json/node_is_primary_ok.json:  "role": "master",                                                                                                                       
tests/json/cluster_has_replica_patroni_verion_3.0.0.json:  "role": "master",                                                                                                 
tests/json/node_is_pending_restart_ko.json:  "role": "master",                                                                                                               
tests/json/node_tl_has_changed.json:  "role": "master",                                                                                                                      
tests/json/node_is_pending_restart_ok.json:  "role": "master",                                                                                                               
tests/json/node_patroni_version.json:  "role": "master",                                                                                                                     
tests/json/node_is_leader_ok.json:  "role": "master",   

@blogh
Copy link
Collaborator Author

blogh commented Oct 8, 2024

updated here: #71

@blogh blogh closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant