WAL bytes are not kilobytes

As opposed to 'sort space used'
dalibo · Oct 13, 2020 · d8f3b5a · d8f3b5a
1 parent 87da22d
commit d8f3b5a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/enums.ts b/src/enums.ts
@@ -135,15 +135,16 @@ export enum NodeProp {
 export enum PropType {
   blocks,
   boolean,
+  bytes,
   cost,
   duration,
   estimateDirection,
   factor,
   increment,
   json,
+  kilobytes,
   list,
   rows,
-  bytes,
 }
 
 export const nodePropTypes: any = {};
@@ -156,7 +157,7 @@ nodePropTypes[NodeProp.STARTUP_COST] = PropType.cost;
 nodePropTypes[NodeProp.TOTAL_COST] = PropType.cost;
 nodePropTypes[NodeProp.PARALLEL_AWARE] = PropType.boolean;
 nodePropTypes[NodeProp.WORKERS] = PropType.json;
-nodePropTypes[NodeProp.SORT_SPACE_USED] = PropType.bytes;
+nodePropTypes[NodeProp.SORT_SPACE_USED] = PropType.kilobytes;
 nodePropTypes[NodeProp.ROWS_REMOVED_BY_FILTER] = PropType.rows;
 nodePropTypes[NodeProp.ROWS_REMOVED_BY_JOIN_FILTER] = PropType.rows;
 nodePropTypes[NodeProp.HEAP_FETCHES] = PropType.rows;

diff --git a/src/filters.ts b/src/filters.ts
@@ -60,10 +60,14 @@ export function truncate(text: string, length: number, clamp: string): string {
     return text.length > length ? text.slice(0, length) + clamp : text;
 }
 
-export function bytes(value: number): string {
+export function kilobytes(value: number): string {
   return formatBytes(value * 1024);
 }
 
+export function bytes(value: number): string {
+  return formatBytes(value);
+}
+
 export function formatBytes(value: number, decimals = 2) {
   const k = 1024;
   const dm = decimals < 0 ? 0 : decimals;
@@ -122,6 +126,8 @@ export function formatNodeProp(key: string, value: any, detail: boolean): string
       return JSON.stringify(value, null, 2);
     } else if (nodePropTypes[key] === PropType.bytes) {
       return bytes(value);
+    } else if (nodePropTypes[key] === PropType.kilobytes) {
+      return kilobytes(value);
     } else if (nodePropTypes[key] === PropType.blocks) {
       return blocks(value);
     } else if (nodePropTypes[key] === PropType.list) {