From 843ac06944bb36ba2fa30d25b8a50e3feff2b5cc Mon Sep 17 00:00:00 2001
From: Marion Giusti <marion.giusti@dalibo.com>
Date: Tue, 7 Jan 2025 09:29:15 +0100
Subject: [PATCH] Move "Rows removed by index recheck" from Misc to general
 table

---
 src/components/PlanNodeDetail.vue | 21 +++++++++++++++++++++
 src/enums.ts                      |  2 ++
 src/services/help-service.ts      |  1 +
 3 files changed, 24 insertions(+)

diff --git a/src/components/PlanNodeDetail.vue b/src/components/PlanNodeDetail.vue
index ece979f5..bd8b512a 100644
--- a/src/components/PlanNodeDetail.vue
+++ b/src/components/PlanNodeDetail.vue
@@ -270,6 +270,27 @@ watch(activeTab, () => {
           v-tippy="{ allowHTML: true, content: filterDetailTooltip }"
         ></FontAwesomeIcon>
       </div>
+
+      <div v-if="node[NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK]">
+        <FontAwesomeIcon
+          fixed-width
+          :icon="faFilter"
+          class="text-secondary"
+        ></FontAwesomeIcon>
+        <b> {{ NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK }}: </b>
+        <span class="px-1">{{
+          tilde + formattedProp("ROWS_REMOVED_BY_INDEX_RECHECK")
+        }}</span>
+        <FontAwesomeIcon
+          fixed-width
+          :icon="faInfoCircle"
+          class="text-muted"
+          v-tippy="{
+            content: `Not enough memory, try increasing work_mem`,
+          }"
+        ></FontAwesomeIcon>
+      </div>
+
       <div v-if="node[NodeProp.HEAP_FETCHES]">
         <FontAwesomeIcon
           fixed-width
diff --git a/src/enums.ts b/src/enums.ts
index 3168a382..a3c7d52c 100644
--- a/src/enums.ts
+++ b/src/enums.ts
@@ -52,6 +52,7 @@ export enum NodeProp {
   PLAN_WIDTH = "Plan Width",
   ROWS_REMOVED_BY_FILTER = "Rows Removed by Filter",
   ROWS_REMOVED_BY_JOIN_FILTER = "Rows Removed by Join Filter",
+  ROWS_REMOVED_BY_INDEX_RECHECK = "Rows Removed by Index Recheck",
   ACTUAL_STARTUP_TIME = "Actual Startup Time",
   ACTUAL_TOTAL_TIME = "Actual Total Time",
   ACTUAL_LOOPS = "Actual Loops",
@@ -174,6 +175,7 @@ nodePropTypes[NodeProp.ROWS_REMOVED_BY_FILTER] = PropType.rows
 nodePropTypes[NodeProp.ROWS_REMOVED_BY_JOIN_FILTER] = PropType.rows
 nodePropTypes[NodeProp.ROWS_REMOVED_BY_FILTER_REVISED] = PropType.rows
 nodePropTypes[NodeProp.ROWS_REMOVED_BY_JOIN_FILTER_REVISED] = PropType.rows
+nodePropTypes[NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK] = PropType.rows
 nodePropTypes[NodeProp.HEAP_FETCHES] = PropType.rows
 nodePropTypes[NodeProp.OUTPUT] = PropType.list
 nodePropTypes[NodeProp.SORT_KEY] = PropType.list
diff --git a/src/services/help-service.ts b/src/services/help-service.ts
index ddaa5f49..3066fbd8 100644
--- a/src/services/help-service.ts
+++ b/src/services/help-service.ts
@@ -350,6 +350,7 @@ const notMiscProperties: string[] = [
   NodeProp.NODE_ID,
   NodeProp.ROWS_REMOVED_BY_FILTER,
   NodeProp.ROWS_REMOVED_BY_JOIN_FILTER,
+  NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK,
   NodeProp.ACTUAL_ROWS_REVISED,
   NodeProp.PLAN_ROWS_REVISED,
   NodeProp.ROWS_REMOVED_BY_FILTER_REVISED,