-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel workers under the lead process in the GUI #291
Fix parallel workers under the lead process in the GUI #291
Conversation
I think the sort has to be done in two steps. cf https://docs.python.org/3/howto/sorting.html#sort-stability-and-complex-sorts |
@blogh I think you're right...need some custom sort function...but then...why not to do it in SQL still as I proposed in the first patch - currently actually I think there are no alternative view modes for "Running queries" where rows can be re-ordered in the UI ? |
@kmoppel-cognite : we can change the sort order while the display is paused. I need to test if it breaks things. I'll try to look into this next week on the following one. |
So ... we don't sort when paused. Do you tink it' s ok ? |
... of course I forgot mypy ... after black ... |
cfc6e42
to
1e2ecf5
Compare
1e2ecf5
to
dd41baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed/changed a few minor things based on @blogh commit, rebased and squashed.
LGTM as is; the parallel worker issue can be addressed in a separate changeset.
I think the way parallel processes are handled is just broken
Opened #297 to track this.
|
Currently they're jumping around annoyingly. Relevant for vers >= 9.6
where parallel query was added