Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

Prevent incorrect revision numbers #141

Merged
merged 3 commits into from
Dec 8, 2019
Merged

Prevent incorrect revision numbers #141

merged 3 commits into from
Dec 8, 2019

Conversation

scott-8
Copy link
Contributor

@scott-8 scott-8 commented Dec 5, 2019

This is to prevent the AOSP build number in sargo-vendor from updating if a build crashes. I had something happen where the build didn't finish, but sargo-vendor had already updated so the following builds thought AOSP was up-to-date

Similarly, I added some steps when checking if Chromium is updated to see if has been actually included in the most recent build. Currently, if a build dies after Chromium has been built, the revision number is updated even though the build never finished, so the script won't detect any need for changes on the next build. To prevent building Chromium repeatedly, I added a parameter to check if the most recent version built was included in the last release.

Look these over and let me know what you think, or if you have anything else in mind. I tested these changes but also please check if I made a mistake somewhere.

@dan-v
Copy link
Owner

dan-v commented Dec 8, 2019

Nice! These are great changes @scott-8!

@dan-v dan-v merged commit 50ad399 into dan-v:10.0 Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants