This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Fix missing notifications in Messaging app #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I wasn't getting any notifications from the default Messaging app, seems that the SDK version is set too high without Google adding the logic code for it.
I'm surprised no one else has noticed this, so feel free to ignore this PR if it you can't replicate it. I'm building AOSP locally based on your script (thanks for making it!). So it's possible I'm getting a different version of the Messaging app somehow.
Tested on my sargo. QQ1A.191205.011 , android-10.0.0_r16
The quick hacky fix that was implemented:
https://android.googlesource.com/platform/packages/apps/Messaging/+/8e71d1b707123e1b48b5529b1661d53762922400%5E!/
The logic they should have merged:
https://developer.android.com/training/notify-user/channels