allow builds with release branches which are newer than the latest factory image #155
Conversation
…ctory image This change should be fully backward compatible and will enable users to build images from the latest release branches for sailfish and marlin devices, even though there are no current factory images. The specific changes are: 1) decouple `AOSP_BUILD` from the automated vendor image search and 2) when the AOSP_BUILD and factory versions differ, write the provided AOSP_BUILD to `build_id.txt` prior to starting the AOSP build. The diff on lines 230 through 251 are largely the result of indentation.
|
Sorry for the delay. Thanks for the PR @khimaros. This is a good idea in terms of extending marlin/sailfish useful life as you will get AOSP updates just not firmware updates, but still that's better than nothing. I'm a bit unsure if I want to pull this in, primarily because this change is really only useful for supporting legacy devices and marlin/sailfish support will likely disappear when AOSP 11 lands. I guess there is still a decent number of months before that happens though. Can you think of any use cases where this would be useful beyond supporting legacy devices? |
|
My primary use case for this is extending life of legacy devices. I can imagine this will also provide ~1 additional year of life to (currently) non-legacy devices such as blueline. |
|
That's a good point; end of life for taimen/walleye I think is October 2020, so it would be applicable in that situation as well with AOSP 11. I'll pull down the branch and test this out and if all is well I'll pull this in. |
|
Looks good. Thanks for the PR @khimaros |
This change should be fully backward compatible and will enable users to build images from the latest release branches for sailfish and marlin devices, even though there are no current factory images.
The specific changes are: 1) decouple
AOSP_BUILDfrom the automated vendor image search and 2) when the AOSP_BUILD and factory versions differ, write the provided AOSP_BUILD tobuild_id.txtprior to starting the AOSP build.The diff on lines 230 through 251 are largely the result of indentation.