Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

1) README.md update, 2) bug fix #171

Merged
merged 3 commits into from
Sep 26, 2020
Merged

1) README.md update, 2) bug fix #171

merged 3 commits into from
Sep 26, 2020

Conversation

ddxor
Copy link
Contributor

@ddxor ddxor commented Sep 22, 2020

Updating README.md for new awscli output format (region is now parameter #3) and a minor bug fix in cli/build.go.

@dan-v
Copy link
Owner

dan-v commented Sep 25, 2020

@ddxor - thanks for the PR. Could you validate if the following works with your version of the AWS CLI (it does for me on older version aws-cli/2.0.39):
aws ec2 describe-regions --query "Regions[*].RegionName" --output text
If so, would be nice if you could pull that into your PR instead.

@ddxor
Copy link
Contributor Author

ddxor commented Sep 25, 2020

@dan-v confirmed your new syntax works, and updated the PR to reflect.

Interestingly enough, I am running aws-cli/1.16.113, so it's quite possible that my change was necessary because my version was too old. However, this new method works across versions, so hurrah!

@dan-v dan-v merged commit 0a4a55c into dan-v:10.0 Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants