This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Fix for Windows deployment #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failure caused by carriage returns when deployed from Windows
|
Awesome, thanks again for another PR @scott-8. Let me know if you get a successful build. |
|
Was able to build successfully! |
|
Excellent! Thanks a ton for tracking down these two Windows issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that removes the carriage returns from the build script. There are still carriage returns in
main.tfandlambda_spot_function.pybut it seems like those are handled fine.I'm running a test build right now but everything looks good so far. Hopefully fixes #185.