Move admin email into Django setting

[asmacdo]

Fixes #605

This will need a new value DJANGO_DANDI_ADMIN_EMAIL to be added to the production deployment.

I hand tested this by adding (uncommited) log messages to the /api/users/me/ endpoint, but let me know if there's a better way to try this out.

[asmacdo]

Is there a process for using a dandi-cli PR for those integration tests here?

[jjnesbitt]

Thanks for this contribution. This will depend on dandi/dandi-infrastructure#218 being merged, since that will add the required values to our heroku deploy. Once that's merged, this can follow suit (assuming no issues arise).

[jjnesbitt]

Is there a process for using a dandi-cli PR for those integration tests here?

Afaik, not in any way that's worthwhile. I think the best course of action is to merge the PRs in this order:

• Infrastructure
• CLI
• API

[mvandenburgh]

Is there a process for using a dandi-cli PR for those integration tests here?

Afaik, not in any way that's worthwhile. I think in this case the best course of action is just to allow them to fail for this PR, and merge in the order:

• Infrastructure
• API
• CLI

Wouldn't merging the CLI PR before the API PR solve the issue? I'm assuming adding an extra env var doesn't cause the CLI tests to fail.

[jjnesbitt]

Wouldn't merging the CLI PR before the API PR solve the issue? I'm assuming adding an extra env var doesn't cause the CLI tests to fail.

I was under the impression that it wouldn't be possible either way, due to the specifics of how the integration tests are run, but I may have been mistaken about that. Regardless, it doesn't hurt to try to merge the CLI PR first, the worst case scenario is the tests still fail. I'll update that comment.

[yarikoptic]

ok we merged (and should get released)

• Add Dandi admin email setting dandi-cli#1588

[mvandenburgh]

I reran the dandi-cli tests, and they're passing now.

[dandibot]

🚀 PR was released in v0.4.25 🚀

[dandibot]

🚀 PR was released in v0.4.25 🚀