Added more tests

Author: danitome24

packages/foundry/contracts/KiddoPerks.sol

@@ -104,7 +104,10 @@ contract KiddoPerks is Ownable {
     return s_tasks[id];
   }
 
-  function completeTask(uint256 taskId, address by) public onlyOwner {
+  function completeTask(
+    uint256 taskId,
+    address by
+  ) public onlyOwner onlyValidChild(by) {
     if (taskId >= s_taskNextId) {
       revert KiddoPerks__TaskNotFound(taskId);
     }
@@ -138,7 +141,7 @@ contract KiddoPerks is Ownable {
   function isTaskCompletedBy(
     uint256 taskId,
     address by
-  ) public view onlyValidChild(by) returns (bool) {
+  ) public view returns (bool) {
     return s_completedTasksByUser[by][taskId];
   }
 

packages/foundry/test/KiddoPerks.t.sol

@@ -102,7 +102,11 @@ contract KiddoPerksTest is Test {
     assertTrue(isCompleted);
   }
 
-  function testRevertsIfCompletedTaskIdNotExists() public withTaskCreated {
+  function testRevertsIfCompletedTaskIdNotExists()
+    public
+    withTaskCreated
+    withChildCreated
+  {
     uint256 taskId = 4;
     vm.prank(PARENT);
     vm.expectRevert(
@@ -113,7 +117,11 @@ contract KiddoPerksTest is Test {
     kiddoPerks.completeTask(taskId, CHILD_ONE);
   }
 
-  function testRevertsIfCompleteARemovedTask() public withTaskCreated {
+  function testRevertsIfCompleteARemovedTask()
+    public
+    withTaskCreated
+    withChildCreated
+  {
     uint256 taskId = 0;
 
     vm.prank(PARENT);
@@ -178,6 +186,40 @@ contract KiddoPerksTest is Test {
     assertTrue(kiddoPerks.taskBy(id).removed);
   }
 
+  function testRevertsIfNoValidChildTriesToCompleteTask()
+    public
+    withTaskCreated
+  {
+    uint256 taskId = 0;
+    vm.prank(PARENT);
+    vm.expectRevert(
+      abi.encodeWithSelector(
+        KiddoPerks.KiddoPerks__NoValidChild.selector, CHILD_ONE
+      )
+    );
+    kiddoPerks.completeTask(taskId, CHILD_ONE);
+  }
+
+  function testRevertsIfRemovedChildTriesToCompleteTask()
+    public
+    withTaskCreated
+    withChildCreated
+  {
+    uint256 taskId = 0;
+    uint256 childId = 0;
+
+    vm.prank(PARENT);
+    kiddoPerks.removeChild(childId);
+
+    vm.prank(PARENT);
+    vm.expectRevert(
+      abi.encodeWithSelector(
+        KiddoPerks.KiddoPerks__NoValidChild.selector, CHILD_ONE
+      )
+    );
+    kiddoPerks.completeTask(taskId, CHILD_ONE);
+  }
+
   /////////////////////
   //// Perk test
   /////////////////////