Can mint NFT from KiddoPerks contract

Author: danitome24

packages/foundry/contracts/KiddoPerks.sol

@@ -23,7 +23,9 @@ contract KiddoPerks is Ownable {
   error KiddoPerks__CannotCompleteRemovedTask(uint256 id);
   error KiddoPerks__ChildAlreadyRemoved(uint256 id);
   error KiddoPerks__PerkAlreadyRemoved(uint256 id);
-  error KiddoPerks__NotEnoughTokenBalance(uint256 id, address by, uint256 tokensRequired);
+  error KiddoPerks__NotEnoughTokenBalance(
+    uint256 id, address by, uint256 tokensRequired
+  );
   error KiddoPerks__PerkAlreadyRedeemmed(uint256 id, address by);
   error KiddoPerks__NoValidChild(address childAddr);
   error KiddoPerks__CannotMintAnyNFTYet(address who);
@@ -39,13 +41,15 @@ contract KiddoPerks is Ownable {
   uint256 public s_childrenNextId = 0;
 
   mapping(uint256 => Perk) public s_perks;
-  mapping(uint256 perkId => mapping(address by => bool isRedeemed)) public s_perksRedeemedBy;
+  mapping(uint256 perkId => mapping(address by => bool isRedeemed)) public
+    s_perksRedeemedBy;
   uint256 public s_perksNextId = 0;
 
   mapping(uint256 => Task) public s_tasks;
   uint256 public s_taskNextId = 0;
   mapping(address => mapping(uint256 => bool)) public s_completedTasksByUser;
-  mapping(address child => uint256 numTasksCompleted) public s_childNumTasksCompleted;
+  mapping(address child => uint256 numTasksCompleted) public
+    s_childNumTasksCompleted;
 
   struct Task {
     uint256 id;
@@ -91,7 +95,10 @@ contract KiddoPerks is Ownable {
   /**
    * Tasks
    */
-  function createTask(string memory title, uint256 tokensReward) public onlyOwner {
+  function createTask(
+    string memory title,
+    uint256 tokensReward
+  ) public onlyOwner {
     s_tasks[s_taskNextId] = Task(s_taskNextId, title, tokensReward, false);
     s_taskNextId++;
     emit TaskCreated(title);
@@ -103,7 +110,10 @@ contract KiddoPerks is Ownable {
     return s_tasks[id];
   }
 
-  function completeTask(uint256 taskId, address by) public onlyOwner onlyValidChild(by) {
+  function completeTask(
+    uint256 taskId,
+    address by
+  ) public onlyOwner onlyValidChild(by) {
     if (taskId >= s_taskNextId) {
       revert KiddoPerks__TaskNotFound(taskId);
     }
@@ -134,7 +144,10 @@ contract KiddoPerks is Ownable {
     emit TaskRemoved(id);
   }
 
-  function isTaskCompletedBy(uint256 taskId, address by) public view returns (bool) {
+  function isTaskCompletedBy(
+    uint256 taskId,
+    address by
+  ) public view returns (bool) {
     return s_completedTasksByUser[by][taskId];
   }
 
@@ -151,7 +164,10 @@ contract KiddoPerks is Ownable {
   /**
    * Perks
    */
-  function createPerk(string memory title, uint256 tokensRequired) public onlyOwner {
+  function createPerk(
+    string memory title,
+    uint256 tokensRequired
+  ) public onlyOwner {
     Perk memory newPerk = Perk(s_perksNextId, title, tokensRequired, false);
     s_perks[s_perksNextId] = newPerk;
     s_perksNextId++;
@@ -195,13 +211,16 @@ contract KiddoPerks is Ownable {
     Perk memory perk = s_perks[perkId];
     uint256 userTokenBalance = token.balanceOf(msg.sender);
     if (userTokenBalance < perk.tokensRequired) {
-      revert KiddoPerks__NotEnoughTokenBalance(perkId, msg.sender, perk.tokensRequired);
+      revert KiddoPerks__NotEnoughTokenBalance(
+        perkId, msg.sender, perk.tokensRequired
+      );
     }
     if (s_perksRedeemedBy[perkId][msg.sender]) {
       revert KiddoPerks__PerkAlreadyRedeemmed(perkId, msg.sender);
     }
 
-    bool sent = token.transferFrom(msg.sender, address(this), perk.tokensRequired);
+    bool sent =
+      token.transferFrom(msg.sender, address(this), perk.tokensRequired);
     if (!sent) {
       revert("Error on token transfer");
     }
@@ -258,7 +277,7 @@ contract KiddoPerks is Ownable {
    */
   function mintNFTByTaskCompletion() public {
     uint256 numTaskCompletedByChild = s_childNumTasksCompleted[msg.sender];
-    if (numTaskCompletedByChild >= MIN_TASK_COMPLETED_NFT) {
+    if (numTaskCompletedByChild < MIN_TASK_COMPLETED_NFT) {
       revert KiddoPerks__CannotMintAnyNFTYet(msg.sender);
     }
     nft.mintNft(msg.sender, s_childNumTasksCompleted[msg.sender]);

packages/foundry/foundry.toml

@@ -2,7 +2,7 @@
 src = 'contracts'
 out = 'out'
 libs = ['lib']
-fs_permissions = [{ access = "read-write", path = "./"}]
+fs_permissions = [{ access = "read-write", path = "./" }]
 
 [rpc_endpoints]
 default_network = "http://127.0.0.1:8545"
@@ -34,7 +34,7 @@ sepolia = { key = "${ETHERSCAN_API_KEY}" }
 
 [fmt]
 multiline_func_header = "params_first"
-line_length = 120
+line_length = 80
 tab_width = 2
 quote_style = "double"
 bracket_spacing = true

packages/foundry/script/DeployKiddoPerks.s.sol

@@ -3,6 +3,7 @@ pragma solidity ^0.8.19;
 
 import { KiddoPerks } from "../contracts/KiddoPerks.sol";
 import { KDOToken } from "../contracts/KDOToken.sol";
+import { KDONft } from "../contracts/KDONft.sol";
 import { ScaffoldETHDeploy, console } from "./DeployHelpers.s.sol";
 
 contract DeployKiddoPerks is ScaffoldETHDeploy {
@@ -11,8 +12,9 @@ contract DeployKiddoPerks is ScaffoldETHDeploy {
     address PARENT = 0x27dBc64e6C38633eD526d970258372476BCE58C0;
 
     KDOToken token = new KDOToken();
+    KDONft nft = new KDONft();
 
-    KiddoPerks kiddoPerks = new KiddoPerks(token);
+    KiddoPerks kiddoPerks = new KiddoPerks(token, nft);
     console.logString(
       string.concat(
         "KiddoPerks deployed at: ", vm.toString(address(kiddoPerks))

packages/foundry/test/KiddoPerks.t.sol

@@ -4,11 +4,13 @@ pragma solidity ^0.8.13;
 import { Test, console } from "forge-std/Test.sol";
 import { KiddoPerks } from "../contracts/KiddoPerks.sol";
 import { KDOToken } from "../contracts/KDOToken.sol";
+import { KDONft } from "../contracts/KDONft.sol";
 import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol";
 
 contract KiddoPerksTest is Test {
   KiddoPerks public kiddoPerks;
   KDOToken public kdoToken;
+  KDONft public kdoNft;
 
   uint256 constant SMALL_REQUIRED_TOKENS_AMOUNT = 2 * 1e18;
 
@@ -18,8 +20,9 @@ contract KiddoPerksTest is Test {
 
   function setUp() public {
     kdoToken = new KDOToken();
+    kdoNft = new KDONft();
 
-    kiddoPerks = new KiddoPerks(kdoToken);
+    kiddoPerks = new KiddoPerks(kdoToken, kdoNft);
     kiddoPerks.setParent(PARENT);
     kdoToken.transferOwnership(address(kiddoPerks));
   }
@@ -516,6 +519,36 @@ contract KiddoPerksTest is Test {
     kiddoPerks.removeChild(childId);
   }
 
+  /**
+   * NFTs
+   */
+  function testRevertsIfTriesToMintNFTWithNoMinTasksCompletion()
+    public
+    withChildCreated
+    withTaskCreated
+  {
+    vm.startPrank(PARENT);
+    kiddoPerks.createTask("Clean up room", SMALL_REQUIRED_TOKENS_AMOUNT);
+    kiddoPerks.createTask("Make bed", SMALL_REQUIRED_TOKENS_AMOUNT);
+    kiddoPerks.createTask("Brush teeth", SMALL_REQUIRED_TOKENS_AMOUNT);
+    kiddoPerks.createTask("Do homework", SMALL_REQUIRED_TOKENS_AMOUNT);
+    kiddoPerks.createTask("Throw out trash", SMALL_REQUIRED_TOKENS_AMOUNT);
+
+    kiddoPerks.completeTask(0, CHILD_ONE);
+    kiddoPerks.completeTask(1, CHILD_ONE);
+    kiddoPerks.completeTask(2, CHILD_ONE);
+    kiddoPerks.completeTask(3, CHILD_ONE);
+    vm.stopPrank();
+
+    vm.prank(CHILD_ONE);
+    vm.expectRevert(
+      abi.encodeWithSelector(
+        KiddoPerks.KiddoPerks__CannotMintAnyNFTYet.selector, CHILD_ONE
+      )
+    );
+    kiddoPerks.mintNFTByTaskCompletion();
+  }
+
   /**
    * Modifiers
    */