Added more tests on KDONft

Author: danitome24

packages/foundry/contracts/KDONft.sol

@@ -17,6 +17,7 @@ contract KDONft is ERC721 {
   error KDONft__CannotMintNFTMoreThanOnce(address who);
 
   enum TaskMilestone {
+    NONE, // Needed to first comparison. If not, first comparison will revert.
     FIVE,
     TEN,
     TWENTY,

packages/foundry/contracts/KiddoPerks.sol

@@ -127,7 +127,7 @@ contract KiddoPerks is Ownable {
     token.mint(by, taskCompleted.tokensReward);
     emit TokenMinted(by, taskCompleted.tokensReward);
 
-    s_childNumTasksCompleted[by] += 1;
+    s_childNumTasksCompleted[by]++;
   }
 
   function removeTask(
@@ -284,7 +284,7 @@ contract KiddoPerks is Ownable {
         msg.sender, numTaskCompletedByChild
       );
     }
-    nft.mintNft(msg.sender, s_childNumTasksCompleted[msg.sender]);
+    nft.mintNft(msg.sender, numTaskCompletedByChild);
   }
 
   /**

packages/foundry/test/KDONft.t.sol

@@ -7,6 +7,9 @@ import { KDONft } from "../contracts/KDONft.sol";
 contract KDONftTest is Test {
   KDONft kdoNft;
 
+  address immutable CHILD_ONE = makeAddr("baby1");
+  address immutable CHILD_TWO = makeAddr("baby2");
+
   function setUp() public {
     kdoNft = new KDONft();
   }
@@ -34,4 +37,54 @@ contract KDONftTest is Test {
     }
     assert(kdoNft._getMilestone(numTasksCompleted) == expectedMilestone);
   }
+
+  function testMintNftSuccess() public {
+    uint256 tasksCompleted = 10;
+
+    kdoNft.mintNft(CHILD_ONE, tasksCompleted);
+
+    assertEq(kdoNft.ownerOf(0), CHILD_ONE);
+    assertEq(kdoNft.s_nextTokenId(), 1);
+
+    assertEq(
+      uint256(kdoNft.s_childLastNftMinted(CHILD_ONE)),
+      uint256(KDONft.TaskMilestone.TEN)
+    );
+  }
+
+  function testMintRevertIfTasksBelowMinimum() public {
+    uint256 tasksCompleted = 4;
+
+    vm.expectRevert(KDONft.KDONft__MinimumTasksCompletedRequired.selector);
+    kdoNft.mintNft(CHILD_ONE, tasksCompleted);
+  }
+
+  function testMintNftRevertIfSameMilestone() public {
+    uint256 tasksCompleted = 10;
+
+    kdoNft.mintNft(CHILD_ONE, tasksCompleted);
+
+    vm.expectRevert(
+      abi.encodeWithSelector(
+        KDONft.KDONft__CannotMintNFTMoreThanOnce.selector, CHILD_ONE
+      )
+    );
+    kdoNft.mintNft(CHILD_ONE, tasksCompleted);
+  }
+
+  function testMintNftMultipleMilestones() public {
+    kdoNft.mintNft(CHILD_ONE, 10);
+    assertEq(kdoNft.ownerOf(0), CHILD_ONE);
+    assertEq(
+      uint256(kdoNft.s_childLastNftMinted(CHILD_ONE)),
+      uint256(KDONft.TaskMilestone.TEN)
+    );
+
+    kdoNft.mintNft(CHILD_ONE, 20);
+    assertEq(kdoNft.ownerOf(1), CHILD_ONE);
+    assertEq(
+      uint256(kdoNft.s_childLastNftMinted(CHILD_ONE)),
+      uint256(KDONft.TaskMilestone.TWENTY)
+    );
+  }
 }