Skip to content

False possitive regarding asf2mkv's resource.h header #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GoogleCodeExporter opened this issue Aug 14, 2015 · 4 comments
Open

False possitive regarding asf2mkv's resource.h header #11

GoogleCodeExporter opened this issue Aug 14, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Using r101 compiled via cygwin and using this settings

`checkheaders -I "c:\Program Files\Microsoft SDKs\Windows\v7.1\Include" -I 
"c:\Program Files\Microsoft Visual Studio 10.0\VC\include" -I "c:\Program 
Files\Microsoft Visual Studio 10.0\VC\atlmfc\include" --skip macwin32.h --skip 
ipv6prefast.h --skip rpcerr.h --skip rpcmac.h --skip ntddk.h --skip winwlm.h 
asf2mkv\`

I'm getting two messages

`[asf2mkv\asf2mkv.h:29] (style): The included header 'resource.h' is not needed
[asf2mkv\asf2mkvDlg.cpp:26] (style): The included header 'asf2mkv.h' is not 
needed`

I've tried moving resource.h from asf2mkv.h into asf2mkvDlg.cpp (being that 
defined strings are called from this file) but it fails to compile.
Anyway ... sansnom05 from MPC-HC said this is false positive by his eyes.

Now to try to sum it up.

asf2mkv.h is needed in asf2mkvDlg.cpp because resource.h is included in 
asf2mkv.h and those defines are called from asf2mkvDlg.cpp

If that makes any sense :D

Needed files are here -> 
https://sourceforge.net/apps/trac/mpc-hc/browser/trunk/src/apps/asf2mkv

Original issue reported on code.google.com by the.vbm on 6 Sep 2010 at 9:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant