Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ast deprecation warnings #136

Closed

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jan 31, 2024

Description

  • Adapted code for future removal of ast.Num, ast.Str and ast.NameConstant
  • Added tests for stable Python 3.12, alpha 3.13, as well as pypy 3.9 and 3.10
  • Added continue-on-error: true for 2.7 cause it's no longer available with actions/setup-python

Pre-approval checklist (for submitter)

Please complete these steps

  • Passes tests
  • New tests for additional features or changed functionality
  • My name and contribution added to contributors list (or if I'd rather opt out, I've said so in the PR)

@edgarrmondragon edgarrmondragon changed the title Fix ast deprecation warnings Address ast deprecation warnings Feb 9, 2024
@edgarrmondragon
Copy link
Contributor Author

The CodeFactor issues seem to be unrelated?

Copy link
Contributor

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danthedeckie Please review this PR and merge -- it should resolve newer Python ast warnings.

@kurtmckee kurtmckee mentioned this pull request Jun 19, 2024
3 tasks
@edgarrmondragon
Copy link
Contributor Author

All tests (except for Python 2.7) are 🟢 over on my fork: https://github.com/edgarrmondragon/simpleeval/actions/runs/9782703954

Screenshot 2024-07-03 at 12 04 56 p m

@edgarrmondragon
Copy link
Contributor Author

Ping @danthedeckie

@danthedeckie
Copy link
Owner

Thanks @edgarrmondragon !

I've merged this via #146 , using a slightly different method now that it makes sense to drop old old pythons.

Thank you for helping push this all forward.

@edgarrmondragon
Copy link
Contributor Author

Thank you @danthedeckie!

@edgarrmondragon edgarrmondragon deleted the futureproof branch October 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants